Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adding memory usage warning with nbresuse#8437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
blink1073 merged 3 commits intojupyterlab:masterfromGsbreddy:master
May 18, 2020
Merged

Adding memory usage warning with nbresuse#8437

blink1073 merged 3 commits intojupyterlab:masterfromGsbreddy:master
May 18, 2020

Conversation

@Gsbreddy
Copy link
Member

This PR will address the issue Adding memory usage warning with nbresuse#8280

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch onbinder, follow this link:Binder

@blink1073
Copy link
Contributor

Hi@Gsbreddy, thanks for making your first contribution! It looks like the linter isn't happy, can you please runjlpm run lint locally and push those changes? Also, can you please include a screenshot showing the style change?

@blink1073blink1073 added this to the2.2 milestoneMay 18, 2020
@Gsbreddy
Copy link
MemberAuthor

Sure thing.

@Gsbreddy
Copy link
MemberAuthor

Hey@blink1073 , I checked the lint and pushed the changes.

@blink1073
Copy link
Contributor

Thanks! Can you please also include a screenshot of the statusbar showing the warning style? You can trigger high memory usage in ipykernel with something likea = [1] * (10 ** 6).

@Gsbreddy
Copy link
MemberAuthor

Gsbreddy commentedMay 18, 2020•
edited
Loading

@blink1073 Here you go.
image

Copy link
Contributor

@blink1073blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thank you!

saibtech171 reacted with thumbs up emoji
@blink1073blink1073 merged commit4fe4dcf intojupyterlab:masterMay 18, 2020
@meeseeksmachine
Copy link
Contributor

This pull request has been mentioned onJupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbresuse-seeking-new-maintainers/2530/11

@github-actionsgithub-actionsbot added the status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion. labelFeb 9, 2021
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 9, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@blink1073blink1073blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg:statusbarstatus:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@Gsbreddy@blink1073@meeseeksmachine
[8]ページ先頭
©2009-2025 Movatter.jp