Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
define base shareUrl#7906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
define base shareUrl#7906
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
allows simplest override of "get shareable link" extension when sharing setup is the same,just on a different base URL.And set this when run under JupyterHub, so folks get proper shareable links by default
Thanks for making a pull request to JupyterLab! To try out this branch onbinder, follow this link: |
Contributor
jasongrout commentedFeb 21, 2020
Setting as 2.0 since we are still waiting on a few other fixes for 2.0. |
blink1073 approved these changesFeb 22, 2020
Contributor
blink1073 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, thanks!
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
pkg:coreutilspkg:filebrowserstatus:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows simplest override of "get shareable link" extension when sharing setup is the same, just on a different base URL.
And set this when run under JupyterHub, so folks get proper shareable links to /hub/user-redirect by default.
References
related to#5388 which made the share extension overrideable. I initially set out to do exactly that, but since the only change for JupyterHub is that of the base URL, I thought making the base share URL itself part of page config would cover the default Hub case, at least.
jupyterhub cross-ref:jupyterhub/jupyterhub#2017
Code changes
User-facing changes
No changes for most users. JupyterHub users using 'get shareable link' will get
actually shareable links to
/hub/user-redirect/lab/tree/...instead of links totheir own server, which are often not accessible to other users.
Backwards-incompatible changes