Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
restores silent failure behavior when a fileType has no iconClass#7027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch onbinder, follow this link: |
blink1073 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
jasongrout commentedAug 16, 2019
@meeseeksdev backport to 1.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
References
The first fix for the new icon handling stuff from the recently merged#6034
Code changes
bugfix to
IconRegistryUser-facing changes
Previously, if a
FileTypewas missing aniconClassfield, Jlab would fail silently when opening a new document of that type (and show no icon on the document's tab). This restores that behavior.Backwards-incompatible changes