Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

restores silent failure behavior when a fileType has no iconClass#7027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@telamonian
Copy link
Member

References

The first fix for the new icon handling stuff from the recently merged#6034

Code changes

bugfix toIconRegistry

User-facing changes

Previously, if aFileType was missing aniconClass field, Jlab would fail silently when opening a new document of that type (and show no icon on the document's tab). This restores that behavior.

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch onbinder, follow this link:Binder

Copy link
Contributor

@blink1073blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@blink1073blink1073 merged commit8190b83 intojupyterlab:masterAug 16, 2019
@jasongroutjasongrout added this to the1.1 milestoneAug 16, 2019
@jasongrout
Copy link
Contributor

@meeseeksdev backport to 1.0.x

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.0.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 8190b83c941ee28e72c9d501522c9c7ae4c26aec
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #7027: restores silent failure behavior when a fileType has no iconClass'
  1. Push to a named branch :
git push YOURFORK 1.0.x:auto-backport-of-pr-7027-on-1.0.x
  1. Create a PR against branch 1.0.x, I would have named this PR:

"Backport PR#7027 on branch 1.0.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@locklockbot added the status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion. labelSep 15, 2019
@locklockbot locked asresolvedand limited conversation to collaboratorsSep 15, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@blink1073blink1073blink1073 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@telamonian@jasongrout@blink1073

[8]ページ先頭

©2009-2025 Movatter.jp