Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Design work on collapser and cells for the beta#3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
blink1073 merged 3 commits intojupyterlab:masterfromellisonbg:collapser-cell-work
Dec 19, 2017

Conversation

@ellisonbg
Copy link
Contributor

  • Removes some stale styling of collapser
  • Styles collapser in console
  • Fixed console styles
  • Minor design updates to new cell view

@ellisonbg
Copy link
ContributorAuthor

Looks like there is still a rendering problem with the collapser on firefox latest. Working on that now...

@ellisonbg
Copy link
ContributorAuthor

OK, talked with@blink1073 and@afshin:

  • Moved away from changing the width of the collapser on hover, was too flickery. Now using a more traditional mostly flat button design (see screenshots below).
  • Narrowed width of collapser to 8px, using minor box shadow and color change on hover.
  • Using simpler console design.
  • Also starting to use 2px border radius on buttons.

This is ready for review.

Dark theme, active, but not hovered:

screen shot 2017-12-18 at 10 42 34 am

Dark theme, active, input collapser hovered to show minor drop shadow and color change:

screen shot 2017-12-18 at 10 42 42 am

Light theme, active, but not hovered:

screen shot 2017-12-18 at 10 42 49 am

Light theme, active, input collapser hovered to show minor drop shadow and color change:

screen shot 2017-12-18 at 10 42 55 am

@ellisonbg
Copy link
ContributorAuthor

And here is the console design:

screen shot 2017-12-18 at 10 48 49 am

Dark theme:

screen shot 2017-12-18 at 10 49 26 am

@blink1073
Copy link
Contributor

Thanks!

@blink1073blink1073 merged commit8ff7d10 intojupyterlab:masterDec 19, 2017
This was referencedDec 23, 2017
@locklockbot added the status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion. labelAug 9, 2019
@locklockbot locked asresolvedand limited conversation to collaboratorsAug 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ellisonbg@blink1073

[8]ページ先頭

©2009-2025 Movatter.jp