Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix visual tests#18216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jasongrout wants to merge7 commits intomain
base:main
Choose a base branch
Loading
fromfixtest
Draft

Fix visual tests#18216

jasongrout wants to merge7 commits intomainfromfixtest

Conversation

@jasongrout
Copy link
Contributor

@jasongroutjasongrout commentedDec 16, 2025•
edited
Loading

References

Code changes

  • Update Python versions to 3.10 to 3.14, matching the current Python versions.
  • Fixjlpm run build:test andjlpm run test by updating services-extension, workspace-extension, audio-extension, and video-extension package.json files to delete test scripts since the respective test files do not exist.

User-facing changes

Backwards-incompatible changes

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

services-extension, workspace-extension, audio-extension, and video-extension had test scripts in their package.json files, but no test files.
@brichet
Copy link
Contributor

@jasongrout I wonder if we should not revert the updated snapshot in#18151 to fix the mermaid test.

@jasongrout
Copy link
ContributorAuthor

@jasongrout I wonder if we should not revert the updated snapshot in#18151 to fix the mermaid test.

Thanks for the suggestion! Happy to experiment with that to see if it fixes things. Do you think that is when problems with the mermaid test started?

@brichet
Copy link
Contributor

Thanks for the suggestion! Happy to experiment with that to see if it fixes things. Do you think that is when problems with the mermaid test started?

Not sure, but it seems to me that most failures I saw were about this snapshot, that looks more like the previous one.
That said, the test passed in this PR without updating it, which means that it would still be flaky if we update it I guess...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@jasongroutjasongrout

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasongrout@brichet
[8]ページ先頭
©2009-2025 Movatter.jp