Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Linter: enforce "import type" when applicable#18129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for making a pull request to jupyterlab! |
jasongrout commentedDec 13, 2025
I pasted my update instructions in the original description to make it easier to find, especially since github is now hiding the relevant comment. |
jasongrout commentedDec 13, 2025
My thought on merging this: let's see what we can do to get the merge queue down in the next week or so by merging PRs, then merge this. That cuts down on the number of PRs we'd need to update and makes it easier to backport any PRs to 4.5, then we can easily update this PR and merge. |
Uh oh!
There was an error while loading.Please reload this page.
References
Similar tojupyterlite/jupyterlite#1786
Description
To regenerate this PR, or I think to update any other PR to not conflict with this, apply this patch:
You can apply the patch by copying it to your clipboard, then doing
then pasting the contents of the clipboard. If you are on a mac, you should instead be able to do
pbpaste | git apply, or a similar command on linux likewl-paste | git apply.Then run
jlpm run eslint, then commit twice. In the first commit attempt, the precommit hook will run prettier to fix up some files, then commit for real the second time.