Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Checkapp.shell.currentWidget for updating the tab title, if available#17772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Checkapp.shell.currentWidget for updating the tab title, if available#17772
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for making a pull request to jupyterlab! |
for more information, seehttps://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks like this change comes from thepre-commit app being reactivated:jupyterlab/jupyter-ai#1388 (comment)
krassowski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@jtpio!
e0ce38e intojupyterlab:mainUh oh!
There was an error while loading.Please reload this page.
References
This should help JupyterLite reuse the lab plugin without modifications forjupyterlite/jupyterlite#1684, instead of having to redefine a full plugin providing
StateDB.Currently the function checks the URL to find the name of the file:
jupyterlab/packages/apputils-extension/src/index.ts
Lines 383 to 386 in0feb1d3
Code changes
updateTabTitleto take optionsapp.shell.currentWidgetif available, default back to checkingwindow.location.hrefotherwiseUser-facing changes
None for JupyterLab users.
JupyterLite users will see a tab title reflecting the path of the current widget. Testing this patch locally in JupyterLite withjupyterlite/jupyterlite#1684 :
Before
After
Backwards-incompatible changes
None