Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix CommandPalette gets re-rendered even if hidden#17442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@fcollonval
Copy link
Member

References

Fixes#13677

Code changes

  • Bump lumino to include the new algorithm ofWidget.isVisible to be consistent if the widget is within an hidden widget
  • Simplify the code ofListWidget in@jupyterlab/running that was hitting a similar issue.

User-facing changes

Less loaded application - but the gain should not be that much

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

@fcollonval
Copy link
MemberAuthor

I set the target to 4.4.0. Should we backport it to 4.3.x dispite the bump to a new minor version of@lumino/wdigets - although it does have the same API?

@krassowski
Copy link
Member

The previous@lumino/widgets version had some API changes so I would not pull it into 4.3.x, but I think we can still merge it into 4.4.0.

It looks like the integrity test is failing.

Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@fcollonval!

@krassowskikrassowski merged commitaae986f intojupyterlab:mainApr 1, 2025
83 checks passed
@fcollonvalfcollonval deleted the fix/13677-improve-widget-isvisible branchApril 11, 2025 09:57
@fcollonval
Copy link
MemberAuthor

Thanks for fixing the integration test@krassowski

kjayan pushed a commit to kjayan/jupyterlab that referenced this pull requestJun 10, 2025
* Bump lumino packages* Simplify running list code by leveraging new `Widget.isVisible`* Fix integrity* Deduplicate---------Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@krassowskikrassowskikrassowski approved these changes

Assignees

@fcollonvalfcollonval

Projects

None yet

Milestone

4.4.0

Development

Successfully merging this pull request may close these issues.

Command palette gets re-rendered even if hidden

2 participants

@fcollonval@krassowski
[8]ページ先頭
©2009-2025 Movatter.jp