Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add jump to executing/executed cell button#16880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Darshan808
Copy link
Member

@Darshan808Darshan808 commentedOct 18, 2024•
edited
Loading

Fixes#16867

Description

Adds an optional button in the execution indicator tooltip that allows users to quickly navigate to the currently executing cell or the last executed cell.

Changes

  • AddedshowJumpToRecentExecutionButton setting to notebook extension (default:false)
  • Button appears in execution indicator tooltip after first cell execution
  • Clicking the button scrolls to the desired cell

User facing changes

The button appears in the hover tooltip only when enabled and after at least one cell has been executed.

image

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

@Darshan808
Copy link
MemberAuthor

@JasonWeill Can i get this PR labelled as 'hacktoberfest-accepted'. I would really appreciate it.

JasonWeill reacted with thumbs up emoji

@JasonWeillJasonWeill added hacktoberfest-acceptedTemporary label for Hacktoberfest (could be deleted afterwards) enhancement labelsOct 18, 2024
Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

UX thoughts:

  • how will user know that clicking here will cause scroll action? The label just says "kernel status"
  • how can we add more actions in the future? If we make click on the indicator one thing we cannot make it another thing (except for alt + click etc combinations, but these won't work on touch screens)

I would like to explore if we can instead put a button in the tooltip with execution details which shows up on hover. This could solve both points above (if it has a "jump" icon it would be more discoverable, and in the future we could have more buttons). In that case the tooltip shown on hover might need to be more persistent.

I am not 100% sure if what I am proposing is the ideal solution but I believe it is worth exploring/waiting for some more feedback from other folks.

Darshan808 reacted with thumbs up emoji
@jtpiojtpio added this to the4.4.0 milestoneOct 23, 2024
@Darshan808
Copy link
MemberAuthor

@krassowski
Thank you for the feedback! I completely agree that making the feature more user-friendly and flexible for future enhancements. My initial implementation was based on the description in issue#16867 but I'm more than happy to improve it further.

Would you suggest that I start exploring the idea of adding a "jump" button on hover, or would it be better to pause on this feature for now and gather more feedback before proceeding?

@krassowski
Copy link
Member

I think either way is fine. Feedback takes time to accumulate organically, if you are interested in getting this done I would suggest pursuing it actively by sharing sscreenshots/recordings of what you can get working with least amount of effort (and worry about the code quality later) - you can open a topic on discourse or join a call to get more eyes on it. If it is not a high priority thing for you I would personally wait a bit.

@JasonWeill
Copy link
Contributor

I just tried this code, and found an error:

  1. Create a notebook with 100 cells in it
  2. Scroll way down to the bottom, and write code (see below) to sleep for 100 seconds. Run it.
  3. Scroll up to the top, write a cell that saysprint("foo"), run it. This cell is queued.
  4. Scroll to where neither running cell is visible.
  5. Click the progress circle.
  6. Expected: the 100-second sleep cell is focused. Actual: theprint cell is focused.
importtimetime.sleep(100)

@jtpiojtpio modified the milestones:4.4.0,4.5.0Apr 8, 2025
@jtpio
Copy link
Member

Nice, thanks for working on this!

Wondering if this feature could then be expanded (not necessarily in this PR) to also address:

krassowski reacted with thumbs up emoji

@github-actionsgithub-actionsbot added tag:Testing tag:CSSFor general CSS related issues and pecadilloes Design System CSS labelsOct 12, 2025
@Darshan808Darshan808 changed the titleAdd feature to scroll to currently executing cell on progress circle clickAdd jump to executing/executed cell buttonOct 12, 2025
@Darshan808
Copy link
MemberAuthor

Just got back to working on this PR after a while. Made some updates (and edited the PR description above). Would love feedback!

@Darshan808Darshan808 removed the hacktoberfest-acceptedTemporary label for Hacktoberfest (could be deleted afterwards) labelOct 14, 2025
Comment on lines +670 to +672
// Auto-enable recordTiming if jump button is enabled
if(displayOptions.showJumpToCell){
constrecordTiming=newSettings.get('recordTiming')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why is this needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is why:

/**
* Go to the last cell that is run or current if it is running.
*
* Note: This requires execution timing to be toggled on or this will have
* no effect.
*
*@param notebook - The target notebook widget.
*/
exportfunctionselectLastRunCell(notebook:Notebook):void{
letlatestTime:Date|null=null;

Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this makes sense. It is opt-in so should not cause much of an issue. The only think I would suggest is to make the description clearer.

I am also not sure if we should use "jump" or "scroll" in UI.

Copy link
Member

@krassowskikrassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One more thing, we don't usebtn in public CSS class names, lets keep it explicit.

@Darshan808
Copy link
MemberAuthor

Darshan808 commentedOct 28, 2025•
edited
Loading

I am also not sure if we should use "jump" or "scroll" in UI.

I think "scroll" makes more sense here!
But the scroll is so fast that it’s barely visible, so I guess using "jump" is fine.

@krassowskikrassowski merged commit99d9789 intojupyterlab:mainOct 29, 2025
120 of 122 checks passed
font-size:var(--jp-ui-font-size1);
border:1px solidvar(--jp-border-color2);
color:var(--jp-ui-font-color0);
transition: all0.1s ease;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
transition: all 0.1s ease;

This causes a slight delay in the disappearance of "Jump to cell" when the indicator loses hover:

Screencast.from.2025-12-12.13-29-47.mp4

Without transition:

Screencast.from.2025-12-12.13-32-14.mp4

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@krassowskikrassowskikrassowski approved these changes

+1 more reviewer

@YahiewiYahiewiYahiewi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Darshan808Darshan808

Labels

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

Clicking the status circle should go to the current executing cell

5 participants

@Darshan808@krassowski@JasonWeill@jtpio@Yahiewi
[8]ページ先頭
©2009-2025 Movatter.jp