Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Don't show default value for objects in Settings Editor#15380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
krassowski merged 2 commits intojupyterlab:mainfromfirai:dont-show-default-setting-objectNov 11, 2023
Merged
Don't show default value for objects in Settings Editor#15380
krassowski merged 2 commits intojupyterlab:mainfromfirai:dont-show-default-setting-objectNov 11, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for making a pull request to jupyterlab! |
krassowski approved these changesNov 11, 2023
Member
krassowski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you@firai!
Member
krassowski commentedNov 11, 2023
@meeseeksdev please backport to 4.0.x |
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull requestNov 11, 2023
krassowski pushed a commit that referenced this pull requestNov 12, 2023
…Editor (#15392)Co-authored-by: firai <firai.admin@gmail.com>
m158261 pushed a commit to m158261/jupyterlab that referenced this pull requestNov 13, 2023
…5380)* Don't show default value if schema type is `object`* Prettier
krassowski added a commit that referenced this pull requestDec 15, 2023
* Updated input field with more descriptive aria-labels and placeholders* Package integrity updates* Run integrity* Move ID generation to improve render flow* Use ellipsis character for consistency* Add error indicator in Table of Contents (#14784)* feat: add error indicator in toc* test: for error indicator* Update Playwright Snapshots* style: make the error symbol colorblind-accessible* Update Playwright Snapshots* fix: remove from _errorCells when cell is rerun* perf: update error to -0.5 for api compatibility* test: update error status to -0.5* Update Playwright Snapshots* Force text symbol* Update Playwright Snapshots* Update Playwright Snapshots* Update Playwright Snapshots* Revert notebook-panel-1 snapshot update* Robustify test by defining notebook a priori* Update Playwright Snapshots---------Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Remove unnecessary requirement from servicesPlugin (#15362)* [pre-commit.ci] pre-commit autoupdate (#15358)* [pre-commit.ci] pre-commit autoupdateupdates:- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)- [github.com/python-jsonschema/check-jsonschema: 0.27.0 → 0.27.1](python-jsonschema/check-jsonschema@0.27.0...0.27.1)- [github.com/psf/black: 23.9.1 → 23.10.1](psf/black@23.9.1...23.10.1)- [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.1.4](astral-sh/ruff-pre-commit@v0.0.292...v0.1.4)* [pre-commit.ci] auto fixes from pre-commit.com hooksfor more information, seehttps://pre-commit.ci* Alig ruff version* Add ruff exception---------Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Update notebook window on resize if height changes (#15357)* Add a test for resizing notebook (should fail)* Update window on resize* Polish the test* Add the test notebook* Use throttler to limit the number of updatesUsing throttler over debouncer proposed in#15109 becausedebouncer would not show cells progressively during resizeuntil user has stopped resizing.* Open files from errors (#13390)* Create renderer to render errors* WIP tests scaffold* Implement opening files from paths in error renderer* Finish sentence in a comment* Apply suggestions from code reviewCo-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Improve RFC 5147 adherence for ranges* Switch to 0-based line numbers based on RFC5147 2.2.3:"Line position counting starts with zero, so the lineposition before the first line of a text/plain MIMEentity has the line position zero"* Fix undefined check after adding `parseInt`---------Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Bump tj-actions/changed-files from 39.2.0 to 40.0.2 (#15342)Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 39.2.0 to 40.0.2.- [Release notes](https://github.com/tj-actions/changed-files/releases)- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)- [Commits](tj-actions/changed-files@v39.2.0...v40.0.2)---updated-dependencies:- dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* Fix scrolling past long outputs in presence of un-rendered headings (#15356)* Add a test for smooth scrolling over long outputs* Do no scroll when setting the cursor position in md cells* Adjust test name to clarify the test case* Add the test notebook* Clean up the test directory* Fix overreactive scrolling to next cell after `Shift + Enter` (#15288)* Add a test case for#14878* Fix the smart/auto scrolling logic for long itemsItems larger than the size of the viewport were notconsidered by the scroll logic leading to bad UX whensmart/auto scroll was requested on certain operations.* Use pixel-based, cell-height-derived threshold for scrolling* Implement dual behaviour, simplify code, account for top padding* Use greater or equal to avoid scrolling if item fully visible* Update tests to reflect new expectations* Clean up the temp directory after tests* Fix scrolling when dragging files in the file browser (#15318)* Fix scrolling on edges in file browser* Add a simple test* Fix update button in extension manager (#15331)* Fix update button in extension manager* Apply suggestions from code reviewMake action options more flexibleCo-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Fix docs and make install options optional* Add test for update button* Update Playwright Snapshots* Revert spurious snapshot updates---------Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>* added default property (#15346)* Exclude ipynb files in prettier pre-commit (#15378)* Update @jupyter/ydoc in dev_mode (#15383)* Define cells to run as independent of selection (#14996)* Define cells to run as independent of selection* Restore side effects of `runAll()`* Skip optional `slice` argumentCo-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Restore previous behaviour of `runAllBelow()`by making last cell active.---------Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>* Fix highlighting search in an out-of-viewport cell (#15376)* Fix highlighting search in an out-of-viewport cell* Update cells count* Don't show default value for objects in Settings Editor (#15380)* Don't show default value if schema type is `object`* Prettier* Bump axios from 1.3.4 to 1.6.1 (#15385)Bumps [axios](https://github.com/axios/axios) from 1.3.4 to 1.6.1.- [Release notes](https://github.com/axios/axios/releases)- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)- [Commits](axios/axios@v1.3.4...v1.6.1)---updated-dependencies:- dependency-name: axios dependency-type: indirect...Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* Fix connection loop issue with standalone foreign document in LSP (#15262)* Populate* Improve VirtualDocument* Add test* Update packages/lsp/test/document.spec.tsCo-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>---------Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>* Update to TypeScript 5.1 (#14638)* Bump typescript to 5.1.6 and rimraf to 5.0.5* Dedupe the yarn.lock---------Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>* Resolved merge conflict* Package integrity updatesMerged changes from main* Package integrity updates* Package integrity updates* Update Playwright Snapshots* Fixed integrity* Update Playwright Snapshots* Update Playwright Snapshots* Remove spurious snapshot updates* Update the test to reflect the new wording---------Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: EC2 Default User <m158261@users.noreply.github.com>Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>Co-authored-by: Tian Wang <wangtian0312@gmail.com>Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>Co-authored-by: Paul Kim <paulkim3151@gmail.com>Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>Co-authored-by: Divyansh Choudhary <divyanshchoudhary99@gmail.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Nate Bowditch <111072326+nbowditch-einblick@users.noreply.github.com>Co-authored-by: LJMP <24670649+LJMP@users.noreply.github.com>Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>Co-authored-by: firai <firai.admin@gmail.com>Co-authored-by: Duc Trung Le <leductrungxf@gmail.com>Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Fixes#15323
Code changes
Don't show default for
objectsin form UI component, the result of which will always be "Object". I'm not entirely sure where else this component is used, but I don't think the "Default: [object Object]" message would be useful in any case.User-facing changes
After changing a setting that is part of an object, the message "Default: [object Object]" no longer appears below the settings section for the object.
Backwards-incompatible changes
None as far as I know.