Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Align notebook trust behaviour with trust in classic Notebook#14345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
krassowski merged 11 commits intojupyterlab:masterfromkrassowski:more-trust-fixes
Apr 15, 2023

Conversation

@krassowski
Copy link
Member

@krassowskikrassowski commentedApr 8, 2023•
edited
Loading

References

Fixes#12889,fixes#14025,fixes#9765

Code changes

Changes to default trust status:

  • cells created manually by user or automatically due to empty notebook are now always marked as trusted (9021a9c)
  • cells without outputs are:
    • trusted if outputs were cleared by the user (1be14c0 /cd6ed46)
    • not trusted if set by deprecated payload mechanism (see9021a9c)

Signature computation stability fixes:

  • trusted metadata is now removed from markdown/raw cells when changing cell type (f31af67) to prevent nbformat from doing this afterwards which led to different signature upon reload

Visual indicator fixes:

  • only code cells are now considered when counting the number of trusted and total cells for the purpose of trust indicator since the trust concept does not currently apply to non-code cells (16a30f7)

User-facing changes

  • Empty notebook is trusted.
  • Notebook trust is not getting lost after adding cells/changing cell type.
  • Trust status indicator is now useful.

Backwards-incompatible changes

None

This is because in the current Jupyter trust modelonly cells with outputs can be marked as (un)trusted.Further, since nbformat does not like `trusted`metadata on non-code cells we have to remove it,and on our side `.trusted` is always undefinedfor non-code cells.
correct implementation for trust change when clearing outputs
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

@krassowskikrassowski changed the titleMore trust fixesAlign notebook trust behaviour with trust in classic NotebookApr 8, 2023
Comment on lines +380 to +386
metadata:
notebook.notebookConfig.defaultCell==='code'
?{
// This is an empty cell created by user, thus is trusted
trusted:true
}
:{}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This ended up a bit repetitive. A tempting alternative is to modifysharedModel.insertCell to always settrusted: true in metadata if cell type iscode andoutputs are empty. A potential downside of that alternative is that it is not "secure by default", because an innocent extension author might do:

model.sharedModel.insertCell(0,{cell_type:'code'});// and some lines later in the same block of instructionsnotebook.activeCellIndex=0;notebook.activeCell.model.outputs=[anOutputLackingProperSanitisation];

in which case a cell with output potentially not controlled by user would end up marked as trusted.

@krassowski
Copy link
MemberAuthor

bot please update documentation snapshots

@github-actions
Copy link
Contributor

github-actionsbot commentedApr 9, 2023•
edited
Loading

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed:min <- [1st quartile -median -3rd quartile] ->max.

The mean relative comparison is computed with 95% confidence.

Results table
Test filelarge_code_notebooklarge_md_notebook
open
chromium
actual564 <- [644 - 675 - 731] -> 814799 <- [1321 - 1362 - 1401] -> 1599
expected562 <- [647 - 688 - 739] -> 1080719 <- [1311 - 1365 - 1406] -> 1581
Mean relative change-1.3% ± 2.7%2.2% ± 4.0%
switch-from
chromium
actual606 <- [754 - 780 - 801] -> 1015363 <- [404 - 429 - 456] -> 576
expected643 <- [760 - 781 - 804] -> 986362 <- [411 - 432 - 462] -> 578
Mean relative change-0.5% ± 1.8%-0.5% ± 2.6%
switch-to
chromium
actual1225 <- [1314 - 1330 - 1355] -> 1557881 <- [924 - 940 - 966] -> 1090
expected1268 <- [1336 - 1357 - 1404] -> 1591899 <- [936 - 952 - 981] -> 1155
Mean relative change-2.5% ± 1.3%-1.6% ± 1.1%
close
chromium
actual153 <- [168 - 178 - 186] -> 222211 <- [227 - 237 - 254] -> 279
expected144 <- [169 - 177 - 189] -> 293214 <- [232 - 241 - 262] -> 315
Mean relative change-0.6% ± 2.8%-2.6% ± 2.1%

Changes are computed withexpected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cellMemory change: +149 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
ArraySearchMarker1+5 B
ContentDeleted1+16 B
ContentString1+69 B
Detached Text1+76 B
FocusTracker1+276 B
ObservableList1+60 B
OutputArea1+1.4 kB
OutputAreaModel1+115 B
Promise1+20 B
PromiseDelegate1+128 B
ResizeHandle1+47 B
RestorablePool1+304 B
UndoManager1+1.93 kB
WidgetTracker1+976 B
YArray1+164 B
YCodeCell1+107 B
YText1+281 B
Detached DOMStringMap2+96 B
Detached V8EventHandlerNonNull2+80 B
Set2+1.21 kB
YMap2+464 B
StackItem3+1.32 kB
ContentAny4+241 B
ContentType4+64 B
DeleteItem4+80 B
DeleteSet6+988 B
Detached HTMLCollection6+580 B
EventHandler8+267 B
ID10+320 B
Item10+1.21 kB
Detached DOMTokenList13+848 B
Detached Attr14+1.12 kB
Detached HTMLDivElement14+47 kB
Map17+2.64 kB
Signal19+319 B
Detached V8EventListener263+23.4 kB
Detached EventListener265+42.6 kB
(closure)270+18.1 kB
Detached InternalNode323+45.3 kB

Leaking collections:

TypeChangePreviewSize increased at
Array+2[StackItem, ...]
UndoManager.afterTransactionHandlerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.<anonymous>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0
cleanupTransactionshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9
Doc.transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array+10[Item, ...]
addStructhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integratehttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>
typeListInsertGenericsAfterhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenericshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.inserthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set+1Set((anonymous function), ...)
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56
Doc.onhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11
new UndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14
YCodeCell.setUndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:398:33
<unknown>http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1589:15
Array.forEach             <anonymous>
YNotebook.insertCellshttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1588:16
YNotebook.insertCellhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1569:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:416:22
Create a markdown cellMemory change: +211 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
ActivityMonitor1+294 B
ArraySearchMarker1+5 B
AttachmentsModel1+193 B
AttachmentsResolver1+14 B
CodeCellModel1+359 B
ContentString1+69 B
Debouncer1+3.46 kB
Detached HTMLAnchorElement1+324 B
Detached HTMLButtonElement1+5.31 kB
Detached HTMLHeadingElement1+1.08 kB
Error1+3.02 kB
MarkdownCell1+4.72 kB
MarkdownCellModel1+237 B
Poll1+3.43 kB
RenderMimeRegistry1+227 B
RenderedMarkdown1+66 B
Transaction1+860 B
TypeError1+306 B
YArray1+164 B
YArrayEvent1+357 B
YCodeCell1+107 B
YMarkdownCell1+45 B
Detached CSSStyleDeclaration2+124 B
Detached HTMLElement2+352 B
Detached V8EventHandlerNonNull2+5.04 kB
Promise2+3.06 kB
PromiseDelegate2+3.27 kB
UndoManager2+2.38 kB
YText2+490 B
Detached DOMStringMap3+140 B
ObservableMap3+374 B
StackItem3+1.33 kB
DeleteItem4+80 B
YMap4+872 B
ContentAny6+498 B
DeleteSet6+1 kB
ContentType7+112 B
Detached Text7+560 B
Set8+1.72 kB
Detached HTMLDivElement10+30.7 kB
Detached DOMTokenList13+820 B
EventHandler14+459 B
ID14+448 B
Item14+1.85 kB
Detached HTMLCollection17+1.78 kB
Map27+3.89 kB
Signal28+722 B
Detached V8EventListener130+10.9 kB
Detached EventListener132+25.5 kB
(closure)152+37.3 kB
Detached InternalNode162+28.3 kB

Leaking collections:

TypeChangePreviewSize increased at
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33
invokeSlothttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30
invokeSlothttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Array+1[db59720e-1a57-41bb-b7f3-81bfa68d4bb1, ...]
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2560:37
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2555:21
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:355:12
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2676:15
CommandRegistry.executehttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5748:33
CommandRegistry._executeKeyBindinghttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5906:14
CommandRegistry.processKeydownEventhttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5846:18
JupyterLab.evtKeydownhttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:4660:23
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlothttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1352:30
                webpack://jupyterlab/packages/notebook/src/actions.tsx:427:28
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2745:15
Array+2[StackItem, ...]
UndoManager.afterTransactionHandlerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.<anonymous>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0
cleanupTransactionshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9
Doc.transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array+14[Item, ...]
addStructhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integratehttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>
typeListInsertGenericsAfterhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenericshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.inserthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set+2Set((anonymous function), ...)
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56
Doc.onhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11
new UndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14
YCodeCell.setUndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:398:33
<unknown>http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1589:15
Array.forEach             <anonymous>
YNotebook.insertCellshttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1588:16
YNotebook.insertCellhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1569:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:416:22
Create a raw cellMemory change: +149 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
ArraySearchMarker1+5 B
CodeCellModel1+359 B
ContentString1+690 B
Detached CSSStyleDeclaration1+56 B
Detached V8EventHandlerNonNull1+40 B
ObservableMap1+102 B
TypeError1+301 B
YArray1+164 B
YCodeCell1+107 B
YRawCell1+45 B
Detached DOMStringMap2+88 B
Set2+1.26 kB
UndoManager2+2.38 kB
YText2+480 B
StackItem3+1.33 kB
DeleteItem4+80 B
YMap4+872 B
Detached HTMLCollection5+464 B
ContentAny6+568 B
DeleteSet6+1 kB
ContentType7+112 B
Detached DOMTokenList9+528 B
Detached HTMLDivElement9+22.5 kB
Signal11+450 B
EventHandler14+431 B
ID14+448 B
Item14+2.54 kB
Map19+2.83 kB
Object35+29.4 kB
Detached V8EventListener130+10.9 kB
Detached EventListener131+20.4 kB
(closure)140+30.5 kB

Leaking collections:

TypeChangePreviewSize increased at
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlothttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1352:30
                webpack://jupyterlab/packages/notebook/src/actions.tsx:427:28
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2745:15
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10493:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10233:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33
invokeSlothttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10259:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30
invokeSlothttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10702:18
Object.emithttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:10660:17
Array+1[8ae0227e-354c-4109-afaa-afa7294c9fb7, ...]
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2560:37
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2555:21
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:355:12
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2676:15
CommandRegistry.executehttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5748:33
CommandRegistry._executeKeyBindinghttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5906:14
CommandRegistry.processKeydownEventhttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:5846:18
JupyterLab.evtKeydownhttp://localhost:8888/static/lab/jlab_core.dad073511a4e0bb2542f.js:4660:23
Array+2[StackItem, ...]
UndoManager.afterTransactionHandlerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5064:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.<anonymous>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4720:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0
cleanupTransactionshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4722:62
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4843:9
Doc.transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2050:5
Array+14[Item, ...]
addStructhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4295:11
Item.integratehttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:11118:7
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6651:22
Array.forEach                <anonymous>
typeListInsertGenericsAfterhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6624:11
typeListInsertGenericshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:6711:10
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7039:9
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:4829:14
YArray.inserthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:7038:7
Set+2Set((anonymous function), ...)
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56
Doc.onhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:2209:11
new UndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.7c22fc794e51ffbd0e42.js:5084:14
YCodeCell.setUndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:398:33
<unknown>http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1589:15
Array.forEach             <anonymous>
YNotebook.insertCellshttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1588:16
YNotebook.insertCellhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.a4c17770813817b2b11a.js:1569:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:416:22
✔ Adding a cell (234615ms) - Drag and drop a cell

File editor memory leaks

Create a fileMemory change: +210 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
Detached HTMLUListElement1+3.44 kB
Detached V8EventHandlerNonNull1+40 B
VirtualElementPass1+46 B
Detached ElementIntersectionObserverData2+144 B
Detached HTMLButtonElement2+23.9 kB
Detached SVGCircleElement2+1.12 kB
HTMLDivElement2+2.67 kB
LabIcon2+1.08 kB
Detached CSSStyleDeclaration3+240 B
Detached HTMLLIElement3+6.42 kB
Detached NodeList3+204 B
NavigationHistoryEntry3+720 B
VirtualText3+106 B
Detached SVGGElement4+3 kB
VirtualElement4+2.49 kB
Detached SVGAnimatedPreserveAspectRatio5+320 B
Detached SVGAnimatedRect5+320 B
Detached SVGPathElement5+1.81 kB
Detached SVGSVGElement5+8.17 kB
Detached HTMLSpanElement6+2.38 kB
Detached DOMStringMap7+440 B
Detached SVGAnimatedNumber7+448 B
Detached Attr10+800 B
Detached Text10+1.08 kB
Detached HTMLCollection13+1.43 kB
Detached DOMTokenList14+920 B
Detached HTMLDivElement15+34.4 kB
DOMRectReadOnly16+896 B
Detached SVGAnimatedString16+896 B
Detached SVGAnimatedTransformList16+1.02 kB
Detached SVGAnimatedLength26+1.66 kB
Array42+6.21 kB
Detached V8EventListener130+10.9 kB
Detached EventListener131+20.4 kB
(closure)138+25.7 kB
✔ Opening a text file (67182ms)

Notebook memory leaks

Create a notebookMemory change: +31.6 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
Detached HTMLUListElement1+2.47 kB
Detached V8EventHandlerNonNull1+40 B
VirtualElementPass1+55 B
Detached ElementIntersectionObserverData2+144 B
Detached HTMLButtonElement2+24.2 kB
Detached SVGCircleElement2+1.12 kB
HTMLDivElement2+241 B
LabIcon2+85 B
Detached CSSStyleDeclaration3+252 B
Detached HTMLLIElement3+6.5 kB
Detached NodeList3+192 B
NavigationHistoryEntry3+720 B
VirtualText3+110 B
VirtualElement4+1.17 kB
Detached SVGAnimatedPreserveAspectRatio5+320 B
Detached SVGAnimatedRect5+320 B
Detached SVGSVGElement5+9.48 kB
Detached HTMLSpanElement6+3.24 kB
Detached SVGGElement6+5.02 kB
Detached SVGPathElement7+2.53 kB
Detached SVGAnimatedNumber9+576 B
Detached Attr10+800 B
Detached Text10+884 B
Detached HTMLCollection13+1.56 kB
Detached DOMTokenList15+1.15 kB
Detached HTMLDivElement15+34.2 kB
Detached SVGAnimatedString20+1.12 kB
Detached SVGAnimatedTransformList20+1.28 kB
Detached SVGAnimatedLength26+1.66 kB
Detached V8EventListener130+10.9 kB
Detached EventListener131+20.4 kB
(closure)138+38.6 kB
✔ Opening a notebook (69715ms)

3 passing (6m)
1 pending

Copy link
Member

@fcollonvalfcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot@krassowski I think I spotted two typos.

Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@krassowskikrassowski merged commited7c879 intojupyterlab:masterApr 15, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@fcollonvalfcollonvalfcollonval approved these changes

Assignees

@krassowskikrassowski

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Notebook trust is different compared to the Classic Notebook Markdown cells break notebook trust Cannot "trust" a notebook with blank cells

2 participants

@krassowski@fcollonval
[8]ページ先頭
©2009-2025 Movatter.jp