Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix save as in collaborative mode#14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fcollonval merged 9 commits intojupyterlab:masterfromhbcarlos:save_as
Mar 16, 2023

Conversation

@hbcarlos
Copy link
Member

@hbcarloshbcarlos commentedMar 13, 2023•
edited
Loading

Fixes#14107

References

This PR was started in#14130 as a fix for lab v3.6. I am opening a new PR because we must also fix it in lab v4.

Code changes

After saving the document with a different name, we do not rename the document in memory. Instead, we close it and open the new one.

User-facing changes

In collaborative mode, we can not rename the document in memory. After a "Save As" action, we need to open the new document and close the old one. By closing the document and opening the new one, we are losing the state of the old document. Most editors do this, and, in my opinion, it is the most predictable behavior.

See#14130 for more context.

Backwards-incompatible changes

Screencast

Grabacion.de.pantalla.2023-03-13.a.las.14.59.33.mov

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

fcollonval
fcollonval previously approved these changesMar 15, 2023
Copy link
Member

@fcollonvalfcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks@hbcarlos

@fcollonvalfcollonval added this to the3.6.x milestoneMar 15, 2023
@fcollonvalfcollonval dismissed theirstale reviewMarch 15, 2023 15:36

Fail on binder with RTC

@fcollonval
Copy link
Member

Sorry for the last minute notice, but there is a bug due to the drive name appearing in theSave As... dialog:

Peek 2023-03-15 16-39

I think it is better to solve it within this PR.

@hbcarlos
Copy link
MemberAuthor

Hey@fcollonval! I changed the dialog not to show the drive name and updated jupyter_collaboration to fix the issue.

Grabacion.de.pantalla.2023-03-15.a.las.21.44.03.mov

Copy link
Member

@fcollonvalfcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@hbcarlos

I checked on binder with RTC and locally

CI failures are not related

@fcollonvalfcollonval merged commit19a41ff intojupyterlab:masterMar 16, 2023
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 19a41ffd8f6f0f8ae8cf3b21ee19df9e47c7e439
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14182: Fix save as in collaborative mode'
  1. Push to a named branch:
git push YOURFORK 3.6.x:auto-backport-of-pr-14182-on-3.6.x
  1. Create a PR against branch 3.6.x, I would have named this PR:

"Backport PR#14182 on branch 3.6.x (Fix save as in collaborative mode)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed:min <- [1st quartile -median -3rd quartile] ->max.

The mean relative comparison is computed with 95% confidence.

Results table
Test filelarge_code_notebooklarge_md_notebook
open
chromium
actual746 <- [807 - 843 - 889] -> 982873 <- [1483 - 1611 - 1675] -> 1903
expected676 <- [785 - 821 - 855] -> 1133804 <- [1407 - 1536 - 1630] -> 2131
Mean relative change⚠️ 3.3% ± 2.1%2.0% ± 5.7%
switch-from
chromium
actual763 <- [857 - 884 - 909] -> 1038341 <- [424 - 455 - 504] -> 612
expected749 <- [822 - 849 - 882] -> 1176336 <- [397 - 419 - 453] -> 596
Mean relative change⚠️ 2.4% ± 1.9%8.6% ± 3.7%
switch-to
chromium
actual1451 <- [1556 - 1637 - 1680] -> 19291031 <- [1117 - 1143 - 1173] -> 1345
expected1412 <- [1502 - 1559 - 1620] -> 1858945 <- [1044 - 1079 - 1129] -> 1293
Mean relative change⚠️ 4.4% ± 1.7%5.2% ± 1.6%
close
chromium
actual176 <- [198 - 207 - 217] -> 257265 <- [291 - 305 - 316] -> 358
expected163 <- [188 - 199 - 207] -> 250234 <- [269 - 284 - 303] -> 352
Mean relative change⚠️ 4.8% ± 2.4%7.0% ± 2.2%

Changes are computed withexpected as reference.

@jupyterlab/benchmarks@1.0.0 test:mocha
mocha ./tests/

Waiting for localhost:8888
localhost:8888 is up

Cell memory leaks

Create a code cellMemory change: +150 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
ArraySearchMarker1+5 B
ContentDeleted1+16 B
ContentString1+72 B
Detached Text1+72 B
FocusTracker1+276 B
ObservableList1+60 B
OutputArea1+1.4 kB
OutputAreaModel1+115 B
Promise1+20 B
PromiseDelegate1+128 B
ResizeHandle1+47 B
RestorablePool1+304 B
UndoManager1+1.93 kB
WidgetTracker1+976 B
YArray1+164 B
YCodeCell1+107 B
YText1+565 B
Detached DOMStringMap2+92 B
Detached V8EventHandlerNonNull2+80 B
Set2+1.21 kB
YMap2+464 B
StackItem3+1.32 kB
ContentAny4+241 B
ContentType4+64 B
DeleteItem4+80 B
DeleteSet6+988 B
Detached HTMLCollection6+552 B
EventHandler8+256 B
ID10+320 B
Item10+1.21 kB
Detached DOMTokenList13+848 B
Detached Attr14+1.01 kB
Detached HTMLDivElement14+46.7 kB
Map17+2.58 kB
Signal19+319 B
Object35+66.7 kB
Array44+14.6 kB
Detached V8EventListener263+23.4 kB
Detached EventListener265+42.6 kB
(closure)270+25.1 kB
Detached InternalNode323+45.1 kB

Leaking collections:

TypeChangePreviewSize increased at
Array+2[StackItem, ...]
UndoManager.afterTransactionHandlerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.<anonymous>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0
cleanupTransactionshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9
Doc.transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array+10[Item, ...]
addStructhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integratehttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>
typeListInsertGenericsAfterhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenericshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5
YArray.inserthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set+1Set((anonymous function), ...)
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56
Doc.onhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
YCodeCell.setUndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33
<unknown>http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>
YNotebook.insertCellshttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCellhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a markdown cellMemory change: -121 kBLeak detected: No

Leaking objects:

Object# addedRetained size increase
ActivityMonitor1+294 B
ArraySearchMarker1+5 B
AttachmentsModel1+193 B
AttachmentsResolver1+14 B
CodeCellModel1+377 B
ContentString1+66 B
Debouncer1+3.46 kB
Detached HTMLAnchorElement1+288 B
Detached HTMLButtonElement1+5.3 kB
Detached HTMLHeadingElement1+912 B
Error1+3.06 kB
MarkdownCell1+4.73 kB
MarkdownCellModel1+237 B
Poll1+3.7 kB
RenderMimeRegistry1+227 B
RenderedMarkdown1+66 B
Transaction1+860 B
TypeError1+301 B
YArray1+164 B
YArrayEvent1+357 B
YCodeCell1+107 B
YMarkdownCell1+45 B
Detached CSSStyleDeclaration2+112 B
Detached HTMLElement2+288 B
Detached V8EventHandlerNonNull2+5.04 kB
Promise2+3.06 kB
PromiseDelegate2+3.27 kB
UndoManager2+2.38 kB
YText2+473 B
Detached DOMStringMap3+128 B
ObservableMap3+381 B
StackItem3+1.33 kB
DeleteItem4+80 B
YMap4+872 B
ContentAny5+524 B
DeleteSet6+1 kB
ContentType7+112 B
Detached Text7+448 B
Set8+1.76 kB
Detached HTMLDivElement10+30.2 kB
Detached DOMTokenList13+752 B
ID13+416 B
Item13+1.78 kB
EventHandler14+442 B
Detached HTMLCollection17+1.7 kB
Map27+12 kB
Signal28+740 B
Detached V8EventListener130+10.9 kB
Detached EventListener132+25.5 kB
(closure)152+7.16 kB
Detached InternalNode162+28.1 kB

Leaking collections:

TypeChangePreviewSize increased at
Array+1[7416ae31-1f77-48bf-90ee-1b00a68c1056, ...]
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2573:15
CommandRegistry.executehttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5748:33
CommandRegistry._executeKeyBindinghttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5906:14
CommandRegistry.processKeydownEventhttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5846:18
JupyterLab.evtKeydownhttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:4660:23
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlothttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2642:15
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33
invokeSlothttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30
invokeSlothttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Array+2[StackItem, ...]
UndoManager.afterTransactionHandlerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.<anonymous>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0
cleanupTransactionshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9
Doc.transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array+13[Item, ...]
addStructhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integratehttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>
typeListInsertGenericsAfterhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenericshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5
YArray.inserthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set+2Set((anonymous function), ...)
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56
Doc.onhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
YCodeCell.setUndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33
<unknown>http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>
YNotebook.insertCellshttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCellhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
Create a raw cellMemory change: -175 kBLeak detected: No

Leaking objects:

Object# addedRetained size increase
ArraySearchMarker1+5 B
CodeCellModel1+359 B
ContentString1+690 B
Detached CSSStyleDeclaration1+60 B
Detached V8EventHandlerNonNull1+40 B
ObservableMap1+109 B
TypeError1+301 B
YArray1+164 B
YCodeCell1+107 B
YRawCell1+45 B
Detached DOMStringMap2+92 B
Set2+1.31 kB
UndoManager2+2.38 kB
YText2+454 B
StackItem3+1.33 kB
DeleteItem4+80 B
YMap4+872 B
ContentAny5+524 B
Detached HTMLCollection5+468 B
DeleteSet6+1 kB
ContentType7+112 B
Detached DOMTokenList9+568 B
Detached HTMLDivElement9+22.5 kB
Signal11+450 B
ID13+416 B
Item13+2.41 kB
EventHandler14+448 B
Map19+11.3 kB
Detached V8EventListener130+10.9 kB
Detached EventListener131+20.4 kB
(closure)140+-6.85 kB
Detached InternalNode151+21.6 kB

Leaking collections:

TypeChangePreviewSize increased at
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/cell-toolbar/src/celltoolbartracker.ts:121:37
invokeSlothttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/widget.ts:1321:30
                webpack://jupyterlab/packages/notebook/src/actions.tsx:408:28
                webpack://jupyterlab/packages/notebook-extension/src/index.ts:2642:15
Array+1[{signal, slot, thisArg}, ...]
Object.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10490:17
Signal.connecthttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10230:24
                webpack://jupyterlab/packages/notebook/src/notebooktools.ts:226:33
invokeSlothttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Signal.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10256:17
                webpack://jupyterlab/packages/notebook/src/tracker.ts:90:30
invokeSlothttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10699:18
Object.emithttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:10657:17
Array+1[90d91961-429c-42b6-af4b-a669994aa18f, ...]
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2425:37
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:2420:21
                                     webpack://jupyterlab/packages/notebook/src/actions.tsx:350:12
                                     webpack://jupyterlab/packages/notebook-extension/src/index.ts:2573:15
CommandRegistry.executehttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5748:33
CommandRegistry._executeKeyBindinghttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5906:14
CommandRegistry.processKeydownEventhttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:5846:18
JupyterLab.evtKeydownhttp://localhost:8888/static/lab/jlab_core.e1a913e5a1839ee16b95.js:4660:23
Array+2[StackItem, ...]
UndoManager.afterTransactionHandlerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5030:15
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.forEach                        <anonymous>
                                     webpack://jupyterlab/node_modules/lib0/observable.js:73:62
Array.<anonymous>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4693:27
                                     webpack://jupyterlab/node_modules/lib0/function.js:19:0
cleanupTransactionshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4695:62
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4810:9
Doc.transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2023:5
Array+13[Item, ...]
addStructhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4268:11
Item.integratehttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:11054:7
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6617:22
Array.forEach                <anonymous>
typeListInsertGenericsAfterhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6590:11
typeListInsertGenericshttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6677:10
<unknown>http://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6996:9
transacthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:4796:5
YArray.inserthttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:6995:7
Set+2Set((anonymous function), ...)
                          webpack://jupyterlab/node_modules/lib0/observable.js:30:56
Doc.onhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:2182:11
new UndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_yjs_dist_yjs_mjs.4fbeace2166db933a6e2.js:5050:14
YCodeCell.setUndoManagerhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:398:33
<unknown>http://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1584:15
Array.forEach             <anonymous>
YNotebook.insertCellshttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1583:16
YNotebook.insertCellhttp://localhost:8888/static/lab/vendors-node_modules_jupyter_ydoc_lib_index_js-node_modules_process_browser_js.fc8babfba933ff460960.js:1564:21
                          webpack://jupyterlab/packages/notebook/src/actions.tsx:404:22
- Drag and drop a cell

File editor memory leaks

Create a fileMemory change: -89.5 kBLeak detected: No

Leaking objects:

Object# addedRetained size increase
Detached HTMLUListElement1+2.3 kB
Detached V8EventHandlerNonNull1+40 B
VirtualElementPass1+46 B
Detached HTMLButtonElement2+23.5 kB
Detached SVGCircleElement2+1.1 kB
HTMLDivElement2+1.11 kB
LabIcon2+1.07 kB
Detached CSSStyleDeclaration3+200 B
Detached HTMLLIElement3+5.17 kB
Detached NodeList3+188 B
NavigationHistoryEntry3+720 B
VirtualText3+109 B
Detached SVGGElement4+2.94 kB
VirtualElement4+969 B
Detached SVGAnimatedPreserveAspectRatio5+320 B
Detached SVGAnimatedRect5+320 B
Detached SVGPathElement5+1.77 kB
Detached SVGSVGElement5+7.91 kB
Detached HTMLSpanElement6+2.22 kB
Detached DOMStringMap7+364 B
Detached SVGAnimatedNumber7+448 B
Detached Attr10+720 B
Detached Text10+696 B
Detached HTMLCollection13+1.37 kB
Detached DOMTokenList14+860 B
Detached HTMLDivElement15+32.6 kB
DOMRectReadOnly16+896 B
Detached SVGAnimatedString16+896 B
Detached SVGAnimatedTransformList16+1.02 kB
Detached SVGAnimatedLength26+1.66 kB
Detached V8EventListener130+10.9 kB
Detached EventListener131+20.4 kB
(closure)138+8.79 kB
✔ Opening a text file (71382ms)

Notebook memory leaks

Create a notebookMemory change: +35.9 kBLeak detected: Yes

Leaking objects:

Object# addedRetained size increase
Detached HTMLUListElement1+2.33 kB
Detached V8EventHandlerNonNull1+40 B
VirtualElementPass1+55 B
Detached HTMLButtonElement2+23.8 kB
Detached SVGCircleElement2+1.1 kB
HTMLDivElement2+-109 B
LabIcon2+935 B
Detached CSSStyleDeclaration3+204 B
Detached HTMLLIElement3+6.04 kB
Detached NodeList3+180 B
NavigationHistoryEntry3+720 B
VirtualText3+111 B
VirtualElement4+1.24 kB
Detached SVGAnimatedPreserveAspectRatio5+320 B
Detached SVGAnimatedRect5+320 B
Detached SVGSVGElement5+9.23 kB
Detached HTMLSpanElement6+3.05 kB
Detached SVGGElement6+4.9 kB
Detached SVGPathElement7+2.47 kB
Detached SVGAnimatedNumber9+576 B
Detached Attr10+720 B
Detached Text10+740 B
Detached HTMLCollection13+1.46 kB
Detached DOMTokenList15+988 B
Detached HTMLDivElement15+33.3 kB
Detached SVGAnimatedString20+1.12 kB
Detached SVGAnimatedTransformList20+1.28 kB
Detached SVGAnimatedLength26+1.66 kB
Detached V8EventListener130+10.9 kB
Detached EventListener131+20.4 kB
(closure)138+38.8 kB
✔ Opening a notebook (75109ms)

2 passing (7m)
1 pending
1 failing

   Adding a cell:  Create a code cell - Objects leaking  + expected - actual  -1357  +1308    at file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:43:16  at Array.forEach (<anonymous>)  at expectNoLeaks (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:28:11)  at testScenario (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/utils.mjs:230:3)  at async Context.<anonymous> (file:///home/runner/work/_actions/jupyterlab/benchmarks/v1/memory-leaks/tests/cell.test.mjs:7:5)

hbcarlos added a commit that referenced this pull requestMar 16, 2023
Backport PR#14182 on branch 3.6.x (Fix save as in collaborative mode)
@hbcarloshbcarlos deleted the save_as branchMarch 20, 2023 09:27
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 21, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@fcollonvalfcollonvalfcollonval approved these changes

Assignees

@hbcarloshbcarlos

Projects

None yet

Milestone

3.6.x

Development

Successfully merging this pull request may close these issues.

SaveAs not working in collaborative mode

2 participants

@hbcarlos@fcollonval
[8]ページ先頭
©2009-2025 Movatter.jp