Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Only show duplicate LabIcon warning in debug mode#12480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fcollonval merged 1 commit intojupyterlab:masterfromajbozarth:labicon-debug
Apr 28, 2022

Conversation

@ajbozarth
Copy link
Member

@ajbozarthajbozarth commentedApr 27, 2022•
edited
Loading

This warning shows up if multiple prebuilt extensions use a library
package to define their icons, which is common.

Redefining previously loaded icon svgstr.

Also note that wrapping the warn in debug is how the warning for looking up a non existent lab icon is handled.

This warning shows up if multiple prebuilt extensions use a librarypackage to define thier icons, which is common.
@ajbozarthajbozarth self-assigned thisApr 27, 2022
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:Binder

@ajbozarthajbozarth changed the titleOnly show duplicate LabIcon in debug modeOnly show duplicate LabIcon warning in debug modeApr 27, 2022
@ajbozarth
Copy link
MemberAuthor

@fcollonval if it would be possible to include this in 3.4? This has been making debugging the front end difficult since Elyra moved to prebuilt extensions as it completely clogs up the console.

@fcollonval
Copy link
Member

if it would be possible to include this in 3.4?

Definitely

@fcollonvalfcollonval added this to the3.4.0 milestoneApr 27, 2022
Copy link
Member

@fcollonvalfcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed:min <- [1st quartile -median -3rd quartile] ->max.

The mean relative comparison is computed with 95% confidence.

Results table
Test filelarge_code_notebooklarge_md_notebook
open
chromium
actual12397 <- [13063 - 13601 - 13759] -> 148572397 <- [2615 - 2659 - 2713] -> 2916
expected12626 <- [13612 - 13954 - 14442] -> 178312524 <- [2716 - 2775 - 2831] -> 3068
Mean relative change-4.5% ± 1.3%-4.3% ± 0.8%
switch-from
chromium
actual511 <- [572 - 589 - 611] -> 667421 <- [447 - 459 - 465] -> 496
expected537 <- [601 - 627 - 645] -> 714423 <- [458 - 471 - 482] -> 508
Mean relative change-5.2% ± 1.4%-2.7% ± 1.0%
switch-to
chromium
actual353 <- [398 - 421 - 446] -> 484259 <- [287 - 295 - 305] -> 329
expected330 <- [410 - 434 - 461] -> 491271 <- [297 - 304 - 312] -> 326
Mean relative change-2.5% ± 2.0%-2.8% ± 1.1%
close
chromium
actual977 <- [1038 - 1067 - 1094] -> 1149415 <- [484 - 492 - 504] -> 544
expected999 <- [1075 - 1101 - 1118] -> 1541458 <- [492 - 503 - 515] -> 573
Mean relative change-3.2% ± 1.2%-2.4% ± 1.0%

Changes are computed withexpected as reference.

@fcollonval
Copy link
Member

CI failure is not related

@fcollonvalfcollonval merged commitc0c79d1 intojupyterlab:masterApr 28, 2022
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.4.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull requestApr 28, 2022
fcollonval pushed a commit that referenced this pull requestApr 28, 2022
@ajbozarthajbozarth deleted the labicon-debug branchApril 28, 2022 15:10
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 29, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@fcollonvalfcollonvalfcollonval approved these changes

Assignees

@ajbozarthajbozarth

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ajbozarth@fcollonval
[8]ページ先頭
©2009-2025 Movatter.jp