Thanks for making a pull request to jupyterlab!
To try out this branch onbinder, follow this link:

I thought our convention was that the toggle status indicated state and the language didn't change. It's confusing for me to see a command checked and the language indicating the negative of the status.

Edit: In other words, it's confusing to me to see✓ Disable pausing on exceptions because it looks like the current state is to disable pausing on exceptions, rather than that is what the command will do. This contrasts with lots of other places where we use the toggle state to reflect the status of the statement, such as various "View" menu items.

I think that we are looking at a different part of the UI@jasongrout. My comment was about the tooltip which currently showsEnable / Disable pausing on exceptions:

But it seems you were thinking about title in the command palette, which already uses the format which you say is undesirable:

I agree that for command palette the current state (i.e prior to this PR) is suboptimal. I think it should be showing "Pause on exceptions" with a tick or without a tick. It would be also useful to use the consistent capitalisation here (also the pause icon needs the css highlight class for contrast or to be removed).

As for the button we should re-consider it's style also because while in 3.3 the background is grey and active button is white, in 4.0 it is reversed (the background is white and active button is grey) which will lead to confusion on future migration.

3.3 vs 4.0 changes apart, it is hard to know if the button is enabled or waiting to be pressed. Changing tooltip as in this PR will help a little (and possibly improve accessibility), but we can improve it a bit more I believe:

Side note: regarding the enable/disable confusion, there is some more ideas on UX stackexchangehere andhere. One suggestion is to avoid buttons for what could be checkboxes.

Let's see what others do:

• Chrome/Edge has tooltips for two states with tooltip "Pause on exceptions" when disabled (indicates action) and "Don't pause on exceptions" when enabled; when action is enabled, an extra checkbox "Pause on caught exceptions" shows up and the button is blue
  
  
• Firefox has a checkbox:
  
• VSCode has a checkbox too:
  

Thanks for the research@krassowski

Ind4860d1 I updated the wording toPause on exceptions forlabel and to a switching caption (so the button title will be switched).