usesserverSettings from the serviceManager (so it can be properly overridden by e.g. jupyterlite)
- also applies this (and the translator and licensesUrl)after the spread ofargs in the command
minor style tweaks
- width of tab bar
- ellipses on long package names (happens)

User-facing changes

By inspection, fixes this tab issue:

Backwards-incompatible changes

Previously, it would have been possible for a command executor to overload trans and licensesUrl, but this doesn't seem like a big loss.

use serverSettings from serviceManager, style tweaks

ec0b4e3

Copy link

jupyterlab-dev-modebot commentedJun 3, 2021

Thanks for making a pull request to JupyterLab!

To try out this branch onbinder, follow this link:

github-actionsbot added Design System CSS pkg:help tag:CSSFor general CSS related issues and pecadilloes labels

Jun 3, 2021

github-actionsbot assignedbollwyvl

Jun 3, 2021

blink1073 added this to the3.1 milestone

Jun 3, 2021

blink1073 added the enhancement label

Jun 3, 2021

blink1073 approved these changes

Jun 3, 2021

View reviewed changes

Copy link

Contributor

blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

blink1073 merged commitded0a02 intojupyterlab:master

Jun 3, 2021

github-actionsbot added the status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label

Dec 1, 2021

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 1, 2021