Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for types in the completer#3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
afshin merged 6 commits intojupyterlab:masterfromellisonbg:completer-fun
Jan 4, 2018

Conversation

@ellisonbg
Copy link
Contributor

Recent versions of IPython add experimental support for adding type data to the list of completions. This is provided by thereply.metadata._jupyter_types_experimental field of the completer reply. Some of the main points of the PR:

  • If the type data is provided by_jupyter_types_experimental render the types visually.
  • Don't make any assumption about the values provided by the kernel. This is done to allow each kernel to provide their own unique type names.
  • Visually encode the types using the category10 colormap of vega (https://github.com/vega/vega/wiki/Scales#scale-range-literals) and a lowercase first letter of the type name (sofunction becomesf).
  • A bit of style cleanup of the completer.

This work uncovered some refactoring of the completer that we should probably do post-beta. I will open a separate PR describing that work.

@ellisonbg
Copy link
ContributorAuthor

Light theme:

screen shot 2018-01-01 at 11 48 35 am

Dark theme:

screen shot 2018-01-01 at 11 49 06 am

@rgbkrk
Copy link
Member

Slick color choices! I think I might just have to switch nteract's current builtin.

@ellisonbgellisonbg changed the title[WIP] Add support for types in the completerAdd support for types in the completerJan 2, 2018
@ellisonbg
Copy link
ContributorAuthor

Based on feedback, new changes include:

  • typeMap is an optional argument tosetOptions
  • Full text of the type is included in the completer UI to the R of the matched text.
  • Align the completer.

Light theme:

screen shot 2018-01-04 at 11 30 23 am

Dark theme:

screen shot 2018-01-04 at 11 30 42 am

Once tests pass this should be ready to merge.

@rgbkrk
Copy link
Member

Awww, I liked the green.

@afshinafshinforce-pushed thecompleter-fun branch 2 times, most recently fromf22b9bf to203f483CompareJanuary 4, 2018 21:39
Copy link
Member

@afshinafshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pretty!

👍

@afshinafshin merged commitfa961f7 intojupyterlab:masterJan 4, 2018
@locklockbot added the status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion. labelAug 9, 2019
@locklockbot locked asresolvedand limited conversation to collaboratorsAug 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@afshinafshinafshin approved these changes

Assignees

@ellisonbgellisonbg

Labels

enhancementpkg:completerstatus:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.tag:Design and UX

Projects

None yet

Milestone

0.31.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ellisonbg@rgbkrk@afshin

[8]ページ先頭

©2009-2025 Movatter.jp