Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Add support for types in the completer#3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
ellisonbg commentedJan 1, 2018
Member
rgbkrk commentedJan 1, 2018
Slick color choices! I think I might just have to switch nteract's current builtin. |
ContributorAuthor
ellisonbg commentedJan 4, 2018
Member
rgbkrk commentedJan 4, 2018
Awww, I liked the green. |
f22b9bf to203f483Compareafshin approved these changesJan 4, 2018
Member
afshin left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pretty!
👍
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
enhancementpkg:completerstatus:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Recent versions of IPython add experimental support for adding type data to the list of completions. This is provided by the
reply.metadata._jupyter_types_experimentalfield of the completer reply. Some of the main points of the PR:_jupyter_types_experimentalrender the types visually.functionbecomesf).This work uncovered some refactoring of the completer that we should probably do post-beta. I will open a separate PR describing that work.