Commit60ce4d7

committed

Delay a mimedocument from being ready until the context is ready.

1 parent1107f69 commit60ce4d7Copy full SHA for 60ce4d7

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -417,15 +417,17 @@ abstract class ABCWidgetFactory<T extends IDocumentWidget, U extends DocumentReg`
`417`	`417`	`export`
`418`	`418`	`classDocumentWidget<TextendsWidget=Widget,UextendsDocumentRegistry.IModel=DocumentRegistry.IModel>extendsMainAreaWidget<T>implementsIDocumentWidget<T,U>{`
`419`	`419`	`constructor(options:DocumentWidget.IOptions<T,U>){`
	`420`	`+`
	`421`	`+// Include the context ready promise in the widget ready promise`
	`422`	`+options.ready=Promise.all([options.ready,options.context.ready]).then(()=>{return;});`
`420`	`423`	`super(options);`
	`424`	`+`
`421`	`425`	`this.context=options.context;`
`422`	`426`
`423`	`427`	`this.context.pathChanged.connect(this._onPathChanged,this);`
`424`	`428`	`this._onPathChanged();`
`425`	`429`	`}`
`426`	`430`
`427`		`-// TODO: redefine the populated/isPopulated to also wait for the context load/rendering`
`428`		`-`
`429`	`431`	`/**`
`430`	`432`	`* Handle a path change.`
`431`	`433`	`*/`

Comments

(0)