NotificationsYou must be signed in to change notification settings
Fork3.8k
Star14.9k

Commit16a30f7

committed

Only count code cells in trust indicator.

This is because in the current Jupyter trust modelonly cells with outputs can be marked as (un)trusted.Further, since nbformat does not like `trusted`metadata on non-code cells we have to remove it,and on our side `.trusted` is always undefinedfor non-code cells.

1 parentf31af67 commit16a30f7Copy full SHA for 16a30f7

File tree

1 file changed

+14

-9

lines changed

packages/notebook/src
- truststatus.tsx

1 file changed

+14

-9

lines changed

`‎packages/notebook/src/truststatus.tsx‎`

Lines changed: 14 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ function cellTrust(`
`27`	`27`	`if(props.trustedCells===props.totalCells){`
`28`	`28`	`return[`
`29`	`29`	`trans.__(`
`30`		`-'Notebook trusted: %1 of %2 cells trusted.',`
	`30`	`+'Notebook trusted: %1 of %2codecells trusted.',`
`31`	`31`	`props.trustedCells,`
`32`	`32`	`props.totalCells`
`33`	`33`	`),`
`@@ -36,7 +36,7 @@ function cellTrust(`
`36`	`36`	`}elseif(props.activeCellTrusted){`
`37`	`37`	`return[`
`38`	`38`	`trans.__(`
`39`		`-'Active cell trusted: %1 of %2 cells trusted.',`
	`39`	`+'Active cell trusted: %1 of %2codecells trusted.',`
`40`	`40`	`props.trustedCells,`
`41`	`41`	`props.totalCells`
`42`	`42`	`),`
`@@ -45,7 +45,7 @@ function cellTrust(`
`45`	`45`	`}else{`
`46`	`46`	`return[`
`47`	`47`	`trans.__(`
`48`		`-'Notebook not trusted: %1 of %2 cells trusted.',`
	`48`	`+'Notebook not trusted: %1 of %2codecells trusted.',`
`49`	`49`	`props.trustedCells,`
`50`	`50`	`props.totalCells`
`51`	`51`	`),`
`@@ -90,12 +90,12 @@ namespace NotebookTrustComponent {`
`90`	`90`	`activeCellTrusted:boolean;`
`91`	`91`
`92`	`92`	`/**`
`93`		`- * The total number of cells for the current notebook.`
	`93`	`+ * The total number ofcodecells for the current notebook.`
`94`	`94`	`*/`
`95`	`95`	`totalCells:number;`
`96`	`96`
`97`	`97`	`/**`
`98`		`- * The number of trusted cells for the current notebook.`
	`98`	`+ * The number of trustedcodecells for the current notebook.`
`99`	`99`	`*/`
`100`	`100`	`trustedCells:number;`
`101`	`101`	`}`
`@@ -145,14 +145,14 @@ export namespace NotebookTrustStatus {`
`145`	`145`	`*/`
`146`	`146`	`exportclassModelextendsVDomModel{`
`147`	`147`	`/**`
`148`		`- * The number of trusted cells in the current notebook.`
	`148`	`+ * The number of trustedcodecells in the current notebook.`
`149`	`149`	`*/`
`150`	`150`	`gettrustedCells():number{`
`151`	`151`	`returnthis._trustedCells;`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`/**`
`155`		`- * The total number of cells in the current notebook.`
	`155`	`+ * The total number ofcodecells in the current notebook.`
`156`	`156`	`*/`
`157`	`157`	`gettotalCells():number{`
`158`	`158`	`returnthis._totalCells;`
`@@ -240,7 +240,7 @@ export namespace NotebookTrustStatus {`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`/**`
`243`		`- * Given a notebook model, figure out how many of the cells are trusted.`
	`243`	`+ * Given a notebook model, figure out how many of thecodecells are trusted.`
`244`	`244`	`*/`
`245`	`245`	`private_deriveCellTrustState(model:INotebookModel\|null):{`
`246`	`246`	`total:number;`
`@@ -249,13 +249,18 @@ export namespace NotebookTrustStatus {`
`249`	`249`	`if(model===null){`
`250`	`250`	`return{total:0,trusted:0};`
`251`	`251`	`}`
	`252`	`+lettotal=0;`
`252`	`253`	`lettrusted=0;`
`253`	`254`	`for(constcellofmodel.cells){`
	`255`	`+if(cell.type!=='code'){`
	`256`	`+continue;`
	`257`	`+}`
	`258`	`+total++;`
`254`	`259`	`if(cell.trusted){`
`255`	`260`	`trusted++;`
`256`	`261`	`}`
`257`	`262`	`}`
`258`		`-return{total:model.cells.length, trusted};`
	`263`	`+return{ total, trusted};`
`259`	`264`	`}`
`260`	`265`
`261`	`266`	`/**`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit16a30f7

File tree

1 file changed

1 file changed

`‎packages/notebook/src/truststatus.tsx‎`

0 commit comments