Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

enable PKCE for internal OAuth#4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
minrk wants to merge1 commit intojupyterhub:main
base:main
Choose a base branch
Loading
fromminrk:pkce
Draft

Conversation

@minrk
Copy link
Member

@minrkminrk commentedOct 21, 2024
edited
Loading

seejupyterhub/oauthenticator#765 for implementing PKCE in OAuthenticator. This does the same in jupyterhub's oauth clients and adds what is needed for the provider side (oauthlib implements the verification, we only need to implement the db persistence of the challenge)

PKCE is currently optional for backward-compatibility

Since this adds db columns, this means a major version bump according to#3982

TODO:

  • opt-in config toenforce PKCE
  • tests
    • failed PKCE validation
    • missing PKCE works when not required
    • missing PKCE doesn't work when PKCE is required
  • explore backward-compatibility implications in HubOAuth defaults
  • update examples (if defaults don't enable PKCE)

It would be nice for PKCE to happen by default, but we need to make sure that existing code will either transparently send both the challenge and the verifier or neither, because e.g. sending the challenge but not the verifier will cause every oauth to fail. Sending neither is still okay as long asrequire_pkce is not enabled, which will be opt-in.

@minrkminrk added the newnew features labelOct 21, 2024
@minrk
Copy link
MemberAuthor

supporting PKCE also opens the door tooauth without client secret, which would enable e.g. javascript applications to login with jupyterhub without a server-side component.

This PR doesn't yet implement that, but it should be a pretty small change after this, Ithink with no db change (e.g.OAuthClient.secret = "").

@minrk
Copy link
MemberAuthor

I'd like to get 5.4 out, then come back to this and require Python 3.10 for jupyterhub 6

manics reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

newnew features

Projects

Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@minrk

[8]ページ先頭

©2009-2025 Movatter.jp