- Notifications
You must be signed in to change notification settings - Fork150
enable multiple launchers (with paths)#267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
bollwyvl wants to merge2 commits intojupyterhub:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+150 −80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
CollaboratorAuthor
bollwyvl commentedApr 18, 2021
ha, bash ate my commit message, but the most recent push should be: |
| "typescript":"~3.7.0" | ||
| "rimraf":"^3.0.2", | ||
| "typescript":"~4.2.4", | ||
| "npm-run-all":"~4.1.5" |
CollaboratorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
makeswatch work as advertised. the typescript/rimraf stuff is just a ride-along.
Contributor
yuvipanda commentedJun 25, 2024
Better nate than lever. Sorry for the late response in reviewing this,@bollwyvl. Wanna rebase and we can try land this? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the configuration in a backwards-compatible way to enable multiple launchers from the same server process.
The public REST API would change (from
launcher_entrytolauncher_entries), as does the URL scheme for the icons<server.name>/<launcher.name>.I opted not to do the submenus, but could.
Additionally, in lab, this makes launcher and layoutrestorer optional, and adds mainmenu and commandpalette, whichshould make this compatible with jupyterlab-classic (though it wouldn't be exposed in the son-of-tree page, and is probably out of scope for this PR).
I didn't see where launcher_entry is under test, but am happy to add something if requested.