- Notifications
You must be signed in to change notification settings - Fork22
Fix IntArray test#32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
minrk wants to merge1 commit intojupyter-widgets:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
dtype is a constructor arg, not a metadata tagI think it was a coincidence that the early bad_value tests failed with old numpy.They pass as dtype=object with recent numpy
bnavigator commentedJan 7, 2023
np.int has been removed from numpy 1.24. This should be plain 'int' now. |
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull requestJan 8, 2023
https://build.opensuse.org/request/show/1056815by user bnavigator + dimstar_suse- Add python-fix-nptypes.patch gh#jupyter-widgets/traittypes#32- Clean specfile, no files catachall- Use PEP517 build (forwarded request 1056814 from bnavigator)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dtype is a constructor arg, not a metadata tag
I think it was a coincidence that the early bad_value tests failed with old numpy. They pass as dtype=object with recent numpy. Test is updated to test integer arrays now.
closes#31