Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Path resolver API#1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
krassowski wants to merge6 commits intojupyter-server:main
base:main
Choose a base branch
Loading
fromkrassowski:ft/resolve-path

Conversation

@krassowski
Copy link
Collaborator

@krassowskikrassowski commentedSep 28, 2023•
edited
Loading

This patch demonstrates the scaffold of the new path resolver API endpoint proposed in#1280.

This depends on a sibling PRjupyter/jupyter_client#1005

Questions:

  • should I useself.kernel_manager orself.multi_kernel_manager? (these are not well documented in code)

In future we could include an entry point (e.g. traitlet) to define additional scopes (e.g. from remote file systems), but this is out of scope for this PR which focuses on distinguishing between a path from kernel and server.

@krassowski
Copy link
CollaboratorAuthor

@meeseeksdev tag enhancement

@lumberbot-app
Copy link

Awww, sorry krassowski you do not seem to be allowed to do that, please ask a repository maintainer.

Wh1isper reacted with laugh emojikrassowski reacted with confused emoji

@krassowskikrassowski changed the title[WIP] Path resolver APIPath resolver APIJan 31, 2024
@krassowski
Copy link
CollaboratorAuthor

Can a repository maintainer add labels to my pull requests or configure lumberbot to make it usable? It helps to see what is the CI status and reduces number of distracting spam emails about failure status.

blink1073 reacted with thumbs up emoji

@blink1073
Copy link
Contributor

I'm afk for the next few days but would merge such a PR. 😃

@krassowski
Copy link
CollaboratorAuthor

Marking this as ready-for review because:

However, if the decision is to go withjupyter/jupyter_client#1006 and close this PR (along withjupyter/jupyter_client#1005) I would totally understand this.

@krassowskikrassowski marked this pull request as ready for reviewMarch 25, 2024 11:54
@krassowski
Copy link
CollaboratorAuthor

Another use case for this API isjupyterlab/jupyterlab#16235 - we currently cannot reliably reconcile the files returned by the debugger with the file system.

@krassowski
Copy link
CollaboratorAuthor

I updatedjupyter/jupyter_client#1005 and it is back to green now.

@krassowski
Copy link
CollaboratorAuthor

jupyter/jupyter_client#1005 was merged but I think we still need to wait for a release.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krassowski@blink1073
[8]ページ先頭
©2009-2025 Movatter.jp