Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix undefined error when checkpoints is empty#7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 1 commit intojupyter:mainfromjdavid:fix-js-undefined-error
Jan 24, 2025

Conversation

@jdavid
Copy link
Contributor

constcheckpoints=awaitcontext?.listCheckpoints();<==ifcheckpointsisanemptyarrayif (!checkpoints) {<==thiswillbefalsereturn;      }constcheckpoint=checkpoints[checkpoints.length-1];<==thencheckpointwillbeundefinednode.textContent=trans.__('Last Checkpoint: %1',Time.formatHuman(newDate(checkpoint.last_modified))<==herewilltriggeranundefinederror      );

We found the problem while integrating jupyterlite with a FastAPI project.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchjdavid/notebook/fix-js-undefined-error

jdavid added a commit to ironArray/Caterva2 that referenced this pull requestJan 23, 2025
jdavid added a commit to ironArray/Caterva2 that referenced this pull requestJan 23, 2025
@jtpiojtpio added the bug labelJan 23, 2025
@jtpiojtpio added this to the7.3.x milestoneJan 23, 2025
Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jtpiojtpio merged commit8b3b5b3 intojupyter:mainJan 24, 2025
33 of 34 checks passed
@jtpio
Copy link
Member

@meeseeksdev please backport to 4.3.x

@lumberbot-app
Copy link

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@jtpio
Copy link
Member

@meeseeksdev please backport to 7.3.x

@jtpio
Copy link
Member

We found the problem while integrating jupyterlite with a FastAPI project.

Do you need this change in JupyterLite soon? It may take a little while to propagate there as this would first need to be available in a Notebook release.

Normally this issue should not have too much of an impact, except for some errors in the dev tools console?

@jdavid
Copy link
ContributorAuthor

In our case the error breaks the notebook, but I don't need the fix quickly, we already patch the file.
Thanks for merging!

jtpio pushed a commit that referenced this pull requestJan 24, 2025
Co-authored-by: J. David Ibáñez <jdavid.ibp@gmail.com>
jdavid added a commit to ironArray/Caterva2 that referenced this pull requestJan 28, 2025
@jtpio
Copy link
Member

FYI@jdavid this is now available in7.3.3:https://github.com/jupyter/notebook/releases/tag/v7.3.3

@jdavid
Copy link
ContributorAuthor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@jdavidjdavid

Labels

Projects

None yet

Milestone

7.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@jdavid@jtpio
[8]ページ先頭
©2009-2025 Movatter.jp