- Notifications
You must be signed in to change notification settings - Fork5.5k
Adds jupyter-ui-toolkit packages in shared scope#7530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jtpio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Left a minor comment, otherwise looks good 👍
app/package.json Outdated
| "@codemirror/state":"~6.4.1", | ||
| "@codemirror/view":"~6.28.3", | ||
| "@jupyter/react-components":"^0.16.6", | ||
| "@jupyter/web-components":"^0.16.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe we can move the@jupyter/ydoc line below next to these new packages, so it's easier to notice (and somewhat sorted) while looking at the resolutions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch, I moved the new entries instead to follow the ASCII order.
brichet commentedDec 4, 2024
Since the corresponding PR in jupyterlab has been published in 4.1, we should probably backport this one to |
jtpio commentedDec 4, 2024
I guess it would be fine to backport to |
21d0306 intojupyter:mainUh oh!
There was an error while loading.Please reload this page.
jtpio commentedDec 4, 2024
@meeseeksdev please backport to 7.2.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
brichet commentedDec 4, 2024
I can do it |
jtpio commentedDec 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
ah meeseek was not able to do the backport, hopefully the manual backport is not too painful since it's just a few lines. |
This PR adds the 2 packages fromjupyter-ui-toolkit in the shared scope of Notebook.
These packages have been included in jupyterlab as singleton injupyterlab/jupyterlab@3d525a2.
Without this change, an extension depending on one of these packages would not work.
Thanks@jtpio for your help on this.