Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds jupyter-ui-toolkit packages in shared scope#7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 2 commits intojupyter:mainfrombrichet:ui-toolkit_shared_scope
Dec 4, 2024

Conversation

@brichet
Copy link
Collaborator

This PR adds the 2 packages fromjupyter-ui-toolkit in the shared scope of Notebook.

These packages have been included in jupyterlab as singleton injupyterlab/jupyterlab@3d525a2.

Without this change, an extension depending on one of these packages would not work.

Thanks@jtpio for your help on this.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchbrichet/notebook/ui-toolkit_shared_scope

@jtpiojtpio added bug maintenance and removed bug labelsDec 4, 2024
@jtpiojtpio added this to the7.3.x milestoneDec 4, 2024
Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

Left a minor comment, otherwise looks good 👍

"@codemirror/state":"~6.4.1",
"@codemirror/view":"~6.28.3",
"@jupyter/react-components":"^0.16.6",
"@jupyter/web-components":"^0.16.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we can move the@jupyter/ydoc line below next to these new packages, so it's easier to notice (and somewhat sorted) while looking at the resolutions?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, I moved the new entries instead to follow the ASCII order.

@brichet
Copy link
CollaboratorAuthor

Since the corresponding PR in jupyterlab has been published in 4.1, we should probably backport this one to7.2.x and7.1.x branches.

@jtpio
Copy link
Member

I guess it would be fine to backport to7.2.x since7.3.0 was released today. Not sure it's worth it for7.1.0 though, unless someone actively requests it, and since it probably affects just a few extensions?

brichet reacted with thumbs up emoji

@jtpiojtpio merged commit21d0306 intojupyter:mainDec 4, 2024
31 checks passed
@brichetbrichet deleted the ui-toolkit_shared_scope branchDecember 4, 2024 15:45
@jtpio
Copy link
Member

@meeseeksdev please backport to 7.2.x

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 7.2.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 21d0306ecef93ea23bf063bc1d8a0580450cd4df
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #7530: Adds jupyter-ui-toolkit packages in shared scope'
  1. Push to a named branch:
git push YOURFORK 7.2.x:auto-backport-of-pr-7530-on-7.2.x
  1. Create a PR against branch 7.2.x, I would have named this PR:

"Backport PR#7530 on branch 7.2.x (Adds jupyter-ui-toolkit packages in shared scope)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@brichet
Copy link
CollaboratorAuthor

I can do it

jtpio reacted with thumbs up emoji

@jtpio
Copy link
Member

jtpio commentedDec 4, 2024
edited
Loading

ah meeseek was not able to do the backport, hopefully the manual backport is not too painful since it's just a few lines.

brichet added a commit to brichet/notebook that referenced this pull requestDec 4, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@brichetbrichet

Projects

None yet

Milestone

7.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@brichet@jtpio

[8]ページ先頭

©2009-2025 Movatter.jp