Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Move handling of the file browser settings to a separate plugin, enable file browser single click navigation#7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 11 commits intojupyter:mainfromjtpio:fix-browser-defaults
Oct 24, 2024
Merged
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
hold ctrl
  • Loading branch information
@jtpio
jtpio committedOct 24, 2024
commitccd78cbd6fa6b56f30daa623ad23a632928c43dd
2 changes: 2 additions & 0 deletionsui-tests/test/filebrowser.spec.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,6 +20,7 @@
test('Select one folder', async ({ page, tmpPath }) => {
await page.filebrowser.refresh();

await page.keyboard.down('Control');
await page.getByText('folder1').last().click();

const toolbar = page.getByRole('toolbar');
Expand All@@ -31,12 +32,13 @@
test('Select one file', async ({ page, tmpPath }) => {
await page.filebrowser.refresh();

await page.keyboard.down('Control');
await page.getByText('empty.ipynb').last().click();

const toolbar = page.getByRole('toolbar');

['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
expect(toolbar.getByText(text)).toBeVisible();

Check failure on line 41 in ui-tests/test/filebrowser.spec.ts

View workflow job for this annotation

GitHub Actions/ ui-tests (firefox)

[firefox] › test/filebrowser.spec.ts:32:7 › File Browser › Select one file

1) [firefox] › test/filebrowser.spec.ts:32:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Open') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Open') 39 | 40 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 41 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 42 | }); 43 | }); 44 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:41:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:40:56
});
});

Expand All@@ -51,7 +53,7 @@
const toolbar = page.getByRole('toolbar');

expect(toolbar.getByText('Rename')).toBeHidden();
expect(toolbar.getByText('Open')).toBeHidden();

Check failure on line 56 in ui-tests/test/filebrowser.spec.ts

View workflow job for this annotation

GitHub Actions/ ui-tests (firefox)

[firefox] › test/filebrowser.spec.ts:45:7 › File Browser › Select files and folders

2) [firefox] › test/filebrowser.spec.ts:45:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeHidden() Locator: getByRole('toolbar').getByText('Open') Expected: hidden Received: visible Call log: - expect.toBeHidden with timeout 5000ms - waiting for getByRole('toolbar').getByText('Open') 54 | 55 | expect(toolbar.getByText('Rename')).toBeHidden(); > 56 | expect(toolbar.getByText('Open')).toBeHidden(); | ^ 57 | expect(toolbar.getByText('Delete')).toBeVisible(); 58 | }); 59 | at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:56:39
expect(toolbar.getByText('Delete')).toBeVisible();
});

Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp