- Notifications
You must be signed in to change notification settings - Fork5.5k
"Close and Shut Down Notebook" shuts down without the confirmation dialog#7384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
jtpio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
stanwest commentedJun 11, 2024
Thanks for addressing the surprising behavior of the dialog. I've opened the above feature request to restore the confirmation dialog. From the perspective of a user, I'm not very concerned with consistency withNotebook 6, but I am very concerned with inadvertently losing the work I have in the kernel. |
Fixes#7359.
In Notebook 6 and nbclassic, the option "Close and Shut Down Notebook" (no ellipsis) in the File menu shuts the current notebook's kernel down immediately, and closes the browser window/tab. In Notebook 7, we had been using the JupyterLab "Close and Shut Down Notebook…" (with ellipsis) command, which causes a dialog to appear. In the interest of NB6 feature parity and consistency with the File menu's command name, this does not ask for additional confirmation before closing the notebook.