👈 Launch a Binder on branchitsmevichu/notebook/workflow-update-jupyterlab-dependencies

Thanks@itsmevichu for looking into this!

Executing "yarn install" post dependency updates results in a substantial amount of modifications, with over 15,000 additions and 15,000 deletions.

Maybe it's because it's using the default yarn (version 1), while the repo here uses yarn 3 viajlpm. So we would probably need to installjupyterlab and usejlpm.

Thanks@itsmevichu.

Looks like this needs a lint pass.

@jtpio The lint check is failing because of the coverage for the scripts. Is it possible for us to exclude the "scripts" folder from coverage checks?

@jtpio I am fetching the latest versions of the lab dependencies from the below URL -https://raw.githubusercontent.com/jupyterlab/jupyterlab/v4.1.4/jupyterlab/staging/package.json.

The package "@jupyterlab/testutils" is not present in the above package.json. As a result, only that specific package won't get updated by this workflow.

@jtpio The lint check is failing because of the coverage for the scripts. Is it possible for us to exclude the "scripts" folder from coverage checks?

Yes I think so. An alternative could be to write the scripts in TypeScript and put them alongside other scripts here:https://github.com/jupyter/notebook/tree/main/buildutils/src

The package "@jupyterlab/testutils" is not present in the above package.json. As a result, only that specific package won't get updated by this workflow.

Right it's fine, we only need to update the packages used here in the notebook repo.

@jtpio I have converted the scripts to typescript and included them in the buildutils.

Pending tasks:

1. To refer the appropriate secrets.

   notebook/.github/workflows/upgrade-juypterlab-dependencies.yml

   Lines 67 to 68 in2154f0f

   	GITHUB_USER:${{ secrets.G_USER }}
   	GITHUB_TOKEN:${{ secrets.G_TOKEN }}

2. Cron job timings.
   

   notebook/.github/workflows/upgrade-juypterlab-dependencies.yml

   Line 5 in2154f0f

   -cron:30 17 * * *

@jtpio Are any changes needed in this PR? If not, we could simply utilize this workflow, as it would minimize the effort required to upgrade dependencies with each JupyterLab release.

It would be really handy to have this in!

It looks like it missed one package,"@jupyterlab/testutils": ~4.2.0

@jtpio I am fetching the latest versions of the lab dependencies from the below URL -https://raw.githubusercontent.com/jupyterlab/jupyterlab/v4.1.4/jupyterlab/staging/package.json.

The package "@jupyterlab/testutils" is not present in the above package.json. As a result, only that specific package won't get updated by this workflow.

I noticed the same, but it seems that the @jupyterlab/testutils information is not present in our source package.json.

I noticed the same, but it seems that the @jupyterlab/testutils information is not present in our source package.json.

I think it is underdevDependencies.

I noticed the same, but it seems that the @jupyterlab/testutils information is not present in our source package.json.

I think it is underdevDependencies.

I've looked through, it appears to be missing from devDependencies. Can I proceed adding it in the respective jupyterlab's package.json?

See this commit:f7f2ead

See this commit:f7f2ead

It seems there was a misunderstanding. The source from which we get the latest release versionhttps://raw.githubusercontent.com/jupyterlab/jupyterlab/v4.2.0/jupyterlab/staging/package.json doesn't include the @jupyterlab/testutils package, which is why the script isn't updating it here. I think we need to add this as a devDependency in the sourcejupyterlab/jupyterlab/staging/package.json first.

Thanks@itsmevichu and sorry for the late reply!

Looks like we could try this workflow for the next updates and iterate on it if needed 👍

The lint failure seems related, I'll push a fix right after.

The other CI failure don't seem related and should hopefully be fixed soon:#7539 (comment)

Looks like it managed to create and push the branch, but failed to open the PR:https://github.com/jupyter/notebook/actions/runs/12435633780/job/34721856783

Opened#7545 to track follow-up improvements.