Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Grayout "Edit Notebook Metadata" for other file formats.#7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Merged
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Grayed out edit notebook metadata
  • Loading branch information
@itsmevichu
itsmevichu committedFeb 16, 2024
commit3ab0ff31934b5cba1131633254696a54b5e54a73
5 changes: 2 additions & 3 deletionspackages/notebook-extension/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -517,7 +517,7 @@ const editNotebookMetadata: JupyterFrontEndPlugin<void> = {
translator: ITranslator | null,
notebookTools: INotebookTools | null
) => {
const { commands } = app;
const { commands, shell } = app;
translator = translator ?? nullTranslator;
const trans = translator.load('notebook');

Expand DownExpand Up@@ -549,8 +549,7 @@ const editNotebookMetadata: JupyterFrontEndPlugin<void> = {
});
}
},
isEnabled: () => { app.shell.currentWidget !== null &&
app.shell.currentWidget instanceof NotebookPanel }
isEnabled: () => shell.currentWidget !== null && shell.currentWidget instanceof NotebookPanel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will need adding some new lines to satisfy linter.
I would consider going as far as hiding it altogether (isVisible?).

itsmevichu reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure, I will incorporate the changes.

});

if (palette) {
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp