Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update ruff config#7190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 2 commits intojupyter:mainfromblink1073:update-ruff-config-again
Dec 19, 2023
Merged

Conversation

@blink1073
Copy link
Contributor

Use updated recommendations for Ruffconfig, and the new ruffdocstring-code-format that replacesblacken-docs.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchblink1073/notebook/update-ruff-config-again

@jtpio
Copy link
Member

Thanks!

The UI tests failure might be relevant? Unless it is caused by a new release of an underlying package?

actual (extra home icon)

image

expected

image

@blink1073
Copy link
ContributorAuthor

I addressed that failure, but it looks like there is a pre-existing race condition, because this firefox test failed with the same error as this chromium test did:https://github.com/jupyter/notebook/actions/runs/7198343749/job/19607743050

@jtpio
Copy link
Member

Thanks!

Is this the same error? Now the issue seems to be related to the trusted indicator not being displayed correctly:

Actual

image

Expected

image

But this is likely not related to this PR, as it also happens in#7191 now.

@blink1073
Copy link
ContributorAuthor

Ah, okay, seems like a race condition.

Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jtpiojtpio merged commit0a08ba3 intojupyter:mainDec 19, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@blink1073blink1073

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blink1073@jtpio
[8]ページ先頭
©2009-2025 Movatter.jp