- Notifications
You must be signed in to change notification settings - Fork5.5k
ci: set minimal permissions to workflows#7070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
ci: set minimal permissions to workflows#7070
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
|
krassowski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!jlpm is just a version-pinned alias foryarn. Underneath a lot is delegated tohttps://github.com/jupyterlab/maintainer-tools so we probably shall review it at some point too.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
jtpio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Uh oh!
There was an error while loading.Please reload this page.
Fixes#7069
Mind that I'm not really familiar with the
jlpmcommands and with some of the jupyter workflows called on some actions, so I recommend that you double-check if I haven't removed any write permission that is actually needed =)