- Notifications
You must be signed in to change notification settings - Fork5.5k
Move opening path in new browser tabs to a separate plugin#7056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Contributor
|
7ae5d98 toe5e9d58Compared14df1e toe5054dfCompareSign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This will help downstreams like JupyterLite configure how they open paths more easily, without having to redefine all the plugins.
Paths can be:
example.pyornotebooks/example.ipynbBy default in Notebook 7 paths are opened are joined with
/, for examplehttps://localhost:8888/notebooks/example.ipynb.In the case of JupyterLite paths are opened by specifying the
?path=query string parameter in the URL, for example:https://localhost:8000/notebooks?path=example.ipynb`.To avoid having downstream applications like JupyterLite have to override several plugins to be able to customize the behavior of
window.open, the path opening logic is moved to a dedicated plugin so only that plugin would need to be redefined in other applications.INotebookPathOpenerto be able to override the URL for opening pathsoptionalto not break existing behavior in potential downstream applications reusing some notebook plugins