👈 Launch a Binder on branchRRosio/notebook/jupytext_url

cool, thanks@RRosio to haven care of this, please let me know if/when this gets released so I can give it a try

@parmentelat were you able to try this change with the built assets for this PR?

@jtpio

Hi; unfortunately no, I am mostly away from keyboard these days
plus, I am not completely comfortable testing unreleased code, as my fuzzy understanding of the build process sometimes leads me to wrong conclusions, and so I tend to stick topip installs as much as I can
So, as much as I'd love to see the issue solved, I'm afraid I am not going to be able to help, at least not for the uncoming release ofnotebook if that's still the plan

I tend to stick topip installs as much as I can

Normally the built artifact (wheel) can be installed just like a released version withpip install. There wouldn't be any major differences between unreleased and released code if this PR gets merged and a new release is made right after.

Likely the most important part would be to make sure it is tested in an isolated virtual environment.

I made quick test

• start from a fresh conda env with python=3.11
• pip install the wheel that I found on this pagehttps://github.com/jupyter/notebook/actions/runs/5478810915 and specifically after extracting the zip found undernotebook-dist-1558
• pip installed the latest jupytext dev wheel (built locally)

however with this setup, on matter how I open a jupytext notebook, I still see the/edit/ url

With the PR I observed that right-clickingOpen with and selectingJupytext Notebook opens the jupytext notebook with the/notebooks route rather than the/edit route. However when double-clicking the jupytext notebook indeed it goes on to open at the/edit route unlike the classic Notebook which after double-clicking opens a jupytext notebook under the/notebooks route.
Is this a matter of updating Notebook 7 so that the double-click behavior be what it was in classic Notebook?

Is this a matter of updating Notebook 7 so that the double-click behavior be what it was in classic Notebook?

Normally double clicking should open the document with its default factory. Without configuration this seems to still beEditor for a Jupytext Notebook:

But testing with this PR and using the user settings provided by@parmentelat in#6914 (comment) to override the default factory, double clicking seems to be opening the file with/notebooks:

But testing with this PR and using the user settings provided by@parmentelat in#6914 (comment) to override the default factory, double clicking seems to be opening the file with/notebooks

Ah okay, I was missing the user settings. Once using those settings, I too witness that same behavior.