- Notifications
You must be signed in to change notification settings - Fork5.5k
Close the browser tab when clicking on "Close and Shut Down Notebook"#6937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
fef47d7936695726bc7b89cab98fe7a8bfc7bb1ae8a651302851aaa3dab98bfedea993b3ffa66c9f3fc6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -145,9 +145,9 @@ const closeTab: JupyterFrontEndPlugin<void> = { | ||||||
| translator = translator ?? nullTranslator; | ||||||
| const trans = translator.load('notebook'); | ||||||
| const id = 'notebook:close-and-halt'; | ||||||
| commands.addCommand(id, { | ||||||
| label: trans.__('Close andHalt'), | ||||||
| ||||||
| label:trans.__('Close andHalt'), | |
| label:trans.__('CloseNotebookandShutdown Kernel'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If going with this suggestion then we'll likely need to useShut Down instead ofShutdown for consistency with the other menu entries.