Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Close the browser tab when clicking on "Close and Shut Down Notebook"#6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 12 commits intojupyter:mainfromjtpio:close-and-shutdown
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
12 commits
Select commitHold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Fix menu entries
  • Loading branch information
@jtpio
jtpio committedJun 20, 2023
commit26bc7b8298f2a7727d29a7cda60b81aa1c8adeda
10 changes: 7 additions & 3 deletionspackages/application-extension/schema/menus.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,12 +15,16 @@
"rank": 20
},
{
"command": "application:close",
"disabled":true
"type": "separator",
"rank":30
},
{
"command": "filemenu:close-and-cleanup",
"rank": 30
"rank": 40
},
{
"command": "application:close",
"disabled": true
}
]
},
Expand Down
4 changes: 2 additions & 2 deletionspackages/notebook-extension/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,9 +145,9 @@ const closeTab: JupyterFrontEndPlugin<void> = {
translator = translator ?? nullTranslator;
const trans = translator.load('notebook');

const id = 'notebook:close-browser-tab';
const id = 'notebook:close-and-halt';
commands.addCommand(id, {
label: trans.__('Close andShut Down Notebook'),
label: trans.__('Close andHalt'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
label:trans.__('Close andHalt'),
label:trans.__('CloseNotebookandShutdown Kernel'),

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If going with this suggestion then we'll likely need to useShut Down instead ofShutdown for consistency with the other menu entries.

execute: async () => {
await commands.execute('notebook:close-and-shutdown');
window.close();
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp