Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix default viewers override#6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 3 commits intojupyter:mainfromjtpio:default-viewers
Jun 19, 2023
Merged

Conversation

@jtpio
Copy link
Member

@jtpiojtpio commentedJun 15, 2023•
edited
Loading

Troubleshooting#6914

Notebook 7 should respect thedefaultViewers settings overrides when opening a document.

Testing with Jupytext with the following:

  • pip install jupytext
  • pip install git+https://github.com/mwouts/jupyterlab-jupytext.git@jupyterlab4

@jtpiojtpio added the bug labelJun 15, 2023
@jtpiojtpio added this to the7.0 milestoneJun 15, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchjtpio/notebook/default-viewers

@jtpiojtpio changed the titleFix default viewers overridesFix default viewers overrideJun 15, 2023
@jtpio
Copy link
MemberAuthor

Still troubleshooting this.

@jtpio
Copy link
MemberAuthor

Looking better:

jupytext-default-viewer.mp4

Although not sure why there is no toolbar when opening the markdown file with theJupytext Notebook factory. This also seems to be an issue with JupyterLab:

default-viewers-jupytext-jupyterlab.mp4

@jtpio
Copy link
MemberAuthor

cc@parmentelat for awareness, since this PR should already help in case you would like to try it out.

As noted above, it seems like there is an issue with the toolbar even with JupyterLab. Maybe this could be addressed as part of the JupyterLab 4 compatibility happening inmwouts/jupyterlab-jupytext#3

consturlParams=newURLSearchParams(parsed.search);
letdefaultFactory=docRegistry.defaultWidgetFactory(path).name;

// Explicitely get the default viewers from the settings because
Copy link
MemberAuthor

@jtpiojtpioJun 16, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we can track that in a JupyterLab issue so it can be discussed.

andrii-i reacted with thumbs up emoji
@jtpiojtpio marked this pull request as ready for reviewJune 16, 2023 13:55
Copy link
Contributor

@andrii-iandrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Main needs to be merged in, otherwise looks good. Thank you@jtpio

@jtpio
Copy link
MemberAuthor

Thanks@andrii-i for the review!

Just rebased and CI all green ✔️

@jtpiojtpio merged commitd069211 intojupyter:mainJun 19, 2023
@jtpiojtpio deleted the default-viewers branchJune 19, 2023 07:36
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@andrii-iandrii-iandrii-i approved these changes

Assignees

@jtpiojtpio

Labels

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jtpio@andrii-i
[8]ページ先頭
©2009-2025 Movatter.jp