Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add an empty splash screen on notebook launch to avoid a flash of unstyled content#6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 4 commits intojupyter:mainfromandrii-i:add_blank_splashscreen
Jun 9, 2023

Conversation

@andrii-i
Copy link
Contributor

@andrii-iandrii-i commentedJun 9, 2023
edited
Loading

Add an empty splash screen on notebook launch to avoid a flash of unstyled content while custom CSS is loading.

Fixes#6790.

Without this PR:

(slowed down)
without_new

without_dark

With this PR:

(slowed down)
with_light_new

with_dark

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchandrii-i/notebook/add_blank_splashscreen

@andrii-iandrii-i added the bug labelJun 9, 2023
@andrii-iandrii-i added this to the7.0 milestoneJun 9, 2023
@andrii-iandrii-i marked this pull request as ready for reviewJune 9, 2023 02:26
activate:(app:JupyterFrontEnd)=>{
const{ restored}=app;
constsplash=document.createElement('div');
splash.style.position='absolute';
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Styling has to be inline or it does not load through on time

jtpio reacted with thumbs up emoji
@andrii-iandrii-i requested a review fromjtpioJune 9, 2023 02:26
Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jtpiojtpio merged commitbdcadda intojupyter:mainJun 9, 2023
@andrii-i
Copy link
ContributorAuthor

Thank you@jtpio

@andrii-iandrii-i deleted the add_blank_splashscreen branchJune 9, 2023 06:05
jitseniesen added a commit to jitseniesen/spyder-notebook that referenced this pull requestJun 29, 2023
jitseniesen added a commit to jitseniesen/spyder-notebook that referenced this pull requestJul 22, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJun 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@andrii-iandrii-i

Labels

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Flash of unstyled content when loading pages

2 participants

@andrii-i@jtpio

[8]ページ先頭

©2009-2025 Movatter.jp