- Notifications
You must be signed in to change notification settings - Fork5.5k
Added extra information and user-action summaries to 7 migration docs.#6850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
echarles commentedApr 25, 2023
Thx@ericsnekbytes I have gone across your changes and they make sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for taking the time to improve the documentation.
Left a couple of comments.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
docs/source/migrate_to_notebook7.md Outdated
| - If you NEED to maintain compatibility with the Classic Notebook for extensions | ||
| or other customizations that are critical to your workflows, you can switch to | ||
| [nbclassic], the new home for users who need to maintain compatibility with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The "new home" and "maintain" words in this sentence give the somewhat misleading idea that nbclassic will be maintained in the long run?
NBClassic is supposed to help with the transition to Notebook 7, but shouldn't be seen as an "alternative" to Notebook 7 long term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah it's a subtle thing to communicate. We want people who need it to know it's there and to use it, without giving the impression it's a permanent thing. I'll add a bit/re-work to add some clarity. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I posted a comment in the team compass issue to see if the EC can provide guidance for the documentation as well, since they will be looking at the blog post:jupyter/notebook-team-compass#24 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I have updated this portion with a recent commit, and we can modify as needed after the EC takes a look.
docs/source/migrate_to_notebook7.md Outdated
| [nbclassic], the new home for users who need to maintain compatibility with the | ||
| old notebook interface | ||
| ##Why things are changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe something like the following?
| ##Whythings are changing | |
| ##Whya new major version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this one is worth keeping, because it simplifies the language and reduces jargon (related to semantic versioning / "major version", which not everyone is going to know about). Maybe there's a plain-language compromise, like "Why the big version change?" Is it the "major-version-number-is-being-incremented-to-7" idea that you want to communicate here?
ericsnekbytesApr 26, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@jtpio Is "Why the big version change?" good? Edit: I've just pushed that, let me know if there's anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"big" sounds ambiguous: what does big mean?
If this is because of the word "major" then maybe we could just drop it and only keep "Why a new version"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Big was supposed to communicate that sweeping changes are taking place in plain-language (without the "major version" jargon and the odd-sounding/confusing phrasing that it necessitates...."Why a new major version" sounds odd, but "Why a major new version" does not...probably related to points noted in this BBC article...).
I've pushed an update to just "Why a new version?" which I think is good enough, let me know if you've got any other suggestions.
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
jtpio commentedApr 27, 2023
Looks like it needs a lint pass to fix the CI check ( |
ericsnekbytes commentedApr 27, 2023
That's done. |
jtpio commentedApr 27, 2023
Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
See#6851, this PR adds extra information to the migrate_to_notebook7 doc: