- Notifications
You must be signed in to change notification settings - Fork5.5k
Change "Interface" menu to "Open in...", shorten names of menu items inside#6847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jtpio commentedApr 20, 2023
Thanks@andrii-i for looking into this! |
andrii-i commentedApr 20, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you for surfacing need to preserve longer wording in command palette@jtpio, it's important not to erode usability. I'm still working on adding conditional option to open in nbclassic if nbclassic is installed but current state of this PR is self-contained and complete for task 1. In case Notebook 7 release would be to happen today, this can be merged as-is |
andrii-i commentedMay 2, 2023
Dynamically detecting nbclassic would require server modification so I will take care of it in a separate PR. |
andrii-i commentedMay 2, 2023
Bot please update playwright snapshots |
jtpio commentedMay 3, 2023
Ah looks like the bot might be broken, but not sure why:https://github.com/jupyter/notebook/actions/runs/4866690782/jobs/8678479167 |
jtpio commentedMay 4, 2023
cc@yuvipanda for awareness |
jtpio commentedMay 4, 2023
@andrii-i actually one of the snapshot failures is relevant. The menu entry should be like the command palette and say "Open in JupyterLab": |
Uh oh!
There was an error while loading.Please reload this page.
andrii-i commentedMay 5, 2023
@jtpio managed to resolve all conflicts, it's all green now 🟢. Manually finding and replacing snapshots is definitely not very optimal and takes time. |
Uh oh!
There was an error while loading.Please reload this page.
jtpio commentedMay 5, 2023
FYI@andrii-i I pushed a small change to avoid the use of an extra command to handle different labels. |
jtpio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
andrii-i commentedMay 5, 2023
Thank you@jtpio |

Uh oh!
There was an error while loading.Please reload this page.
Without this change:

With this change:


