Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change "Interface" menu to "Open in...", shorten names of menu items inside#6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 18 commits intojupyter:mainfromandrii-i:open_with_menu
May 5, 2023

Conversation

@andrii-i
Copy link
Contributor

@andrii-iandrii-i commentedApr 19, 2023
edited
Loading

Without this change:
image

With this change:
Screenshot 2023-04-19 at 9 52 47 PM
Screenshot 2023-04-19 at 9 58 14 PM
image

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchandrii-i/notebook/open_with_menu

@andrii-iandrii-i changed the titleAdd option to open with nbclassicChange "Interface" menu to "Open with...", adjust command names inside, add conditional option to open with nbclassicApr 20, 2023
@andrii-iandrii-i changed the titleChange "Interface" menu to "Open with...", adjust command names inside, add conditional option to open with nbclassicChange "Interface" menu to "Open with...", adjust command names, add conditional option to open with nbclassicApr 20, 2023
@andrii-iandrii-i changed the titleChange "Interface" menu to "Open with...", adjust command names, add conditional option to open with nbclassicChange "Interface" menu to "Open in...", shorten command names inside, add conditional option to open with nbclassicApr 20, 2023
@andrii-iandrii-i changed the titleChange "Interface" menu to "Open in...", shorten command names inside, add conditional option to open with nbclassicChange "Interface" menu to "Open in...", shorten names of menu items inside, add conditional option to open with nbclassicApr 20, 2023
@jtpiojtpio added this to the7.0 milestoneApr 20, 2023
@jtpio
Copy link
Member

Thanks@andrii-i for looking into this!

andrii-i reacted with thumbs up emoji

@andrii-i
Copy link
ContributorAuthor

andrii-i commentedApr 20, 2023
edited
Loading

Thank you for surfacing need to preserve longer wording in command palette@jtpio, it's important not to erode usability. I'm still working on adding conditional option to open in nbclassic if nbclassic is installed but current state of this PR is self-contained and complete for task 1. In case Notebook 7 release would be to happen today, this can be merged as-is

@andrii-iandrii-i changed the titleChange "Interface" menu to "Open in...", shorten names of menu items inside, add conditional option to open with nbclassicChange "Interface" menu to "Open in...", shorten names of menu items insideMay 2, 2023
@andrii-iandrii-i marked this pull request as ready for reviewMay 2, 2023 22:53
@andrii-i
Copy link
ContributorAuthor

Dynamically detecting nbclassic would require server modification so I will take care of it in a separate PR.

@andrii-i
Copy link
ContributorAuthor

Bot please update playwright snapshots

@jtpio
Copy link
Member

Ah looks like the bot might be broken, but not sure why:https://github.com/jupyter/notebook/actions/runs/4866690782/jobs/8678479167

@jtpio
Copy link
Member

cc@yuvipanda for awareness

@jtpio
Copy link
Member

@andrii-i actually one of the snapshot failures is relevant. The menu entry should be like the command palette and say "Open in JupyterLab":

image

@andrii-iandrii-i requested a review fromjtpioMay 5, 2023 01:15
@andrii-i
Copy link
ContributorAuthor

@jtpio managed to resolve all conflicts, it's all green now 🟢. Manually finding and replacing snapshots is definitely not very optimal and takes time.

@jtpio
Copy link
Member

FYI@andrii-i I pushed a small change to avoid the use of an extra command to handle different labels.

andrii-i reacted with thumbs up emoji

Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jtpiojtpio merged commitd7d110c intojupyter:mainMay 5, 2023
@jtpiojtpio mentioned this pull requestMay 5, 2023
2 tasks
@andrii-i
Copy link
ContributorAuthor

Thank you@jtpio

@andrii-iandrii-i deleted the open_with_menu branchMay 5, 2023 17:28
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@andrii-iandrii-i

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Shorten "Interface" menu and options

2 participants

@andrii-i@jtpio

[8]ページ先頭

©2009-2025 Movatter.jp