- Notifications
You must be signed in to change notification settings - Fork5.5k
Remove "Close Tab" menu entry#6843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
|
jtpio commentedApr 20, 2023
Thanks@timmerk3 for looking into it. |
| "rank":20 | ||
| }, | ||
| { | ||
| "type":"submenu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure it should besubmenu here, since the entry appears as a regular single entry?
Also when trying this PR on Binder the menu entry still seems to be displayed:
jtpio commentedMay 14, 2023
FYI@timmerk3 I pushed a small change to fix the config. |
jtpio left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Disables the "Close Tab" menu entry from the file dropdown, brought up in#6832. The user should be the one manually closing the tab.