Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix JSON setting editor not opening issue#6795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 1 commit intojupyter:mainfromyumyumqing:fix-setting-widget
Mar 24, 2023

Conversation

@yumyumqing
Copy link
Contributor

@yumyumqingyumyumqing commentedMar 24, 2023•
edited
Loading

For issue:#6778

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchyumyumqing/notebook/fix-setting-widget

@yumyumqingyumyumqing changed the titleFix JSON setting editor not opening issue (#6778)Fix JSON setting editor not opening issueMar 24, 2023
@yumyumqingyumyumqing marked this pull request as draftMarch 24, 2023 03:41
@jtpiojtpio added this to the7.0 milestoneMar 24, 2023
@jtpiojtpio linked an issueMar 24, 2023 that may beclosed by this pull request
Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

This looks good when testing the PR on Binder:https://mybinder.org/v2/gh/yumyumqing/notebook/fix-setting-widget?urlpath=tree

advanced-settings-editor.mp4

@jtpio
Copy link
Member

@yumyumqing I think we can mark the PR as ready and merge it if that's ok for you?

Just wanted to make sure first in case you wanted to make more changes, but it looks good like this 👍

@yumyumqingyumyumqing marked this pull request as ready for reviewMarch 24, 2023 12:33
@yumyumqing
Copy link
ContributorAuthor

yumyumqing commentedMar 24, 2023•
edited
Loading

Yes thanks@jtpio ! I don't have anything else to add. I have marked it as ready and feel free to merge it now. Thanks again for your help on this!

@jtpio
Copy link
Member

Thanks again!

@jtpiojtpio merged commit77e591a intojupyter:mainMar 24, 2023
@yumyumqingyumyumqing deleted the fix-setting-widget branchApril 6, 2023 01:58
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@yumyumqingyumyumqing

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Settings Editor cannot open after switching to JSON

2 participants

@yumyumqing@jtpio
[8]ページ先頭
©2009-2025 Movatter.jp