Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Help-extension split into multiple plugins#6700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 3 commits intojupyter:mainfromRRosio:split-help-extension
Jan 18, 2023

Conversation

@RRosio
Copy link
Collaborator

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchRRosio/notebook/split-help-extension

@jtpiojtpio added this to the7.0 milestoneJan 18, 2023
@jtpio
Copy link
Member

Thanks@RRosio for working on this!

@RRosioRRosio marked this pull request as ready for reviewJanuary 18, 2023 15:09
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@RRosio
Copy link
CollaboratorAuthor

Thank you@jtpio! I made this change locally however when re-installingnotebook the Help menu option no longer contains theAbout Jupyter Notebook andKeyboard Shortcuts sections. I was thinking maybe I need to update the schema as well?

@jtpio
Copy link
Member

Right, probably this file would need to be renamed then:https://github.com/jupyter/notebook/blob/main/packages/help-extension/schema/plugin.json

@RRosio
Copy link
CollaboratorAuthor

Thank you! I just submitted that change.

@jtpio
Copy link
Member

Thanks!

I just tried on Binder with the latest changes and it looks good:

image

Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jtpiojtpio merged commit6d4eeed intojupyter:mainJan 18, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

@RRosioRRosio

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Split the help extension into multiple plugins

2 participants

@RRosio@jtpio
[8]ページ先頭
©2009-2025 Movatter.jp