Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Initialize handler page_config from Server traitlets#6366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 3 commits intojupyter:mainfrombollwyvl:add-default-page-config
Apr 19, 2022

Conversation

@bollwyvl
Copy link
Contributor

This initializespage_config from, e.g.ServerApp.tornado_settings.page_config_data. These values can be subsequently overwritten by other configurables.

This corresponds toLabHandler injupyterlab_server.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchbollwyvl/notebook/add-default-page-config

@jtpiojtpio added this to the7.0 milestoneApr 19, 2022
@jtpio
Copy link
Member

Thanks!

Looks like this adds the following two items to the File menu (noticed by the UI tests):

image

Which is fine. We can always re-work the snapshots later via the settings system so they look more like the ones from the classic notebook:

image

bollwyvl reacted with thumbs up emoji

Copy link
Member

@jtpiojtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@jtpiojtpio merged commit60f1f01 intojupyter:mainApr 19, 2022
@bollwyvl
Copy link
ContributorAuthor

Thanks!

@bollwyvlbollwyvl deleted the add-default-page-config branchApril 19, 2022 16:38
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jtpiojtpiojtpio approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bollwyvl@jtpio
[8]ページ先頭
©2009-2025 Movatter.jp