Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add the Settings Editor to the landing page#6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jtpio merged 14 commits intojupyter:mainfromjtpio:settings-editor
Jan 13, 2023

Conversation

@jtpio
Copy link
Member

@jtpiojtpio commentedMar 18, 2022•
edited
Loading

This adds the Settings Editor to the existingTabPanel on the landing page (/tree):

settings-editor.mp4

Previous iteration

setting-editor.mp4

TODO

fcollonval reacted with heart emoji
@jtpiojtpio added this to the7.0 milestoneMar 18, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branchjtpio/notebook/settings-editor

@jtpio
Copy link
MemberAuthor

Expose the tab panel for other plugins:

Maybe this would actually be a more sustainable approach for the first 7.0 release. So other types of JupyterLab widgets could be added to that tree panel, so they are all under/tree. Instead of trying to have a generic way to open widgets in new browser tabs?

@jtpio
Copy link
MemberAuthor

Maybe this would actually be a more sustainable approach for the first 7.0 release. So other types of JupyterLab widgets could be added to that tree panel, so they are all under /tree. Instead of trying to have a generic way to open widgets in new browser tabs?

Looks like this could indeed play nicely, especially since it would be similar to how some extra functionalities were being added to the classic notebook before, for example "Clusters" and "Nbextensions":

image

@jtpiojtpio self-assigned thisJan 11, 2023
@jtpiojtpio closed thisJan 12, 2023
@jtpiojtpio reopened thisJan 12, 2023
@jtpio
Copy link
MemberAuthor

Maybe we can keep the settings editor hidden for now by default, so it looks more like the classic notebook.

And add it to the tab panel when opening it via the menu entry:

settings-editor.mp4

@jtpiojtpio marked this pull request as ready for reviewJanuary 12, 2023 17:49
@jtpio
Copy link
MemberAuthor

There is an upstream issue when using the command palette.

Tracked injupyterlab/jupyterlab#13760 and related PR:jupyterlab/jupyterlab#13761

@jtpio
Copy link
MemberAuthor

There is an upstream issue when using the command palette.

Opened#6691 to track this.

@jtpio
Copy link
MemberAuthor

Now looking good for a first step. We can continue iterating in follow-up PRs.

@jtpiojtpio merged commitdf4a6bf intojupyter:mainJan 13, 2023
@jtpiojtpio deleted the settings-editor branchJanuary 13, 2023 07:21
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

@jtpiojtpio

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

1 participant

@jtpio
[8]ページ先頭
©2009-2025 Movatter.jp