NotificationsYou must be signed in to change notification settings
Fork5.5k
Star12.8k

handle KeyError when get session#6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kevin-bates merged 2 commits intojupyter:masterfromccw630:fix_session

Dec 20, 2021

Merged

handle KeyError when get session#6245

kevin-bates merged 2 commits intojupyter:masterfromccw630:fix_session

Dec 20, 2021

Conversation

Copy link

Contributor

ccw630 commentedDec 9, 2021

If gateway is enabled,row_to_model can delete session row when kernel culled or died on gateway. Then it raises aKeyError unhadled inget_session.

handle KeyError when get session

9fa8a87

kevin-bates approved these changes

Dec 9, 2021

View reviewed changes

Copy link

Member

kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM - thank you.

Copy link

ContributorAuthor

ccw630 commentedDec 10, 2021

Wondering if I should make a same PR to repojupyter_server - what's the diffrence between thosebackend code?

Copy link

Member

kevin-bates commentedDec 10, 2021

Yes, that would be helpful, thank you.
Jupyter server was derived directly from notebook but only includes backend code. That is, it is only the server portion.
The notebook repository is essentially in a maintenance-only mode while jupyter_server entertains feature additions, etc. Front-end applications have or are migrating to jupyter_server.