- Notifications
You must be signed in to change notification settings - Fork5.5k
Recover from failure to render mimetype#6181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
SylvainCorlay merged 1 commit intojupyter:masterfrommartinRenou:recover_from_failure_to_render_mimetypeSep 18, 2021
Merged
Recover from failure to render mimetype#6181
SylvainCorlay merged 1 commit intojupyter:masterfrommartinRenou:recover_from_failure_to_render_mimetypeSep 18, 2021
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedSep 15, 2021
Member
SylvainCorlay commentedSep 15, 2021
This looks good to me! |
Uh oh!
There was an error while loading.Please reload this page.
cce6674 to49d1ad9CompareSylvainCorlay approved these changesSep 17, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
It's easier to review the diff while disabling whitespace diffs:https://github.com/jupyter/notebook/pull/6181/files?diff=split&w=1
This is closer to JupyterLab's behavior.
As an example, if a Jupyter widget fails to render (due to widget state not found), we display other available mimetypes instead of nothing.
This goes in the direction of this PR:matplotlib/ipympl#343 (add support for saving a static version of the matplotlib plot next to the widget mimetype) which works properly in JupyterLab but not in Notebook yet.
PR goes in pair withjupyter-widgets/ipywidgets#3280