NotificationsYou must be signed in to change notification settings
Fork5.5k
Star12.8k

Bind the HTTPServer in start#6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

blink1073 merged 1 commit intojupyter:masterfromminrk:bind-in-start

May 13, 2021

Merged

Bind the HTTPServer in start#6061

blink1073 merged 1 commit intojupyter:masterfromminrk:bind-in-start

May 13, 2021

Conversation

Copy link

Member

minrk commentedMay 13, 2021•
edited
Loading

Binding sockets hooks them up to the running eventloop, which we should try to avoid in initialize
in case any other stages may configure the event loop policy

This is ~equivalent tojupyter-server/jupyter_server#517 but in start instead of at the end of initialize.

I think calling listen in start is better, and easier because the bind was already a separate method call that was easy to move.

Bind the HTTPServer in start

36c6b40

Binding sockets hooks them up to the running eventloop, which we should try to avoid in initializein case any other stages may configure the event loop policy