Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add reconnection to Gateway (form nb2kg)#5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@oyvsyo
Copy link
Contributor

@oyvsyooyvsyo commentedJan 5, 2021•
edited
Loading

Mirror logic from
jupyter/nb2kg#45
that implements an exponential backoff algorithm and retry count
limit to prevent too many false API calls in error trying to reconnect to an orphaned session

@kevin-bates@esevan Can we add it here?

Copy link
Member

@kevin-bateskevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@oyvsyo - these changes look good. Just had one comment on the wording.

Once this is merged, we will want to apply this to applicable code injupyter_server/gateway as well. Are you able to make that contribution also?

Co-authored-by: Kevin Bates <kbates4@gmail.com>
@kevin-bates
Copy link
Member

But I have not tested it yet, so maybe we should put it on WIP and I will install notebook from this branch and try to run the gateway?

No worries - thanks! Go ahead and place this into DRAFT mode if it's going to be multiple days, otherwise, just ping back when you're ready.

oyvsyo reacted with thumbs up emoji

@oyvsyooyvsyo marked this pull request as draftJanuary 6, 2021 07:43
@oyvsyo
Copy link
ContributorAuthor

oyvsyo commentedJan 6, 2021•
edited
Loading

was able to reproduce a lost session and get EnterpriseGatewayApp logs listed below:

[I 2021-01-06 11:58:00.621 EnterpriseGatewayApp] Jupyter Enterprise Gateway 2.2.0.dev0 is available at http://0.0.0.0:6666[W 2021-01-06 11:58:04.375 EnterpriseGatewayApp] No session ID specified[W 210106 11:58:04 web:1786] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1): Kernel does not exist: ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9[W 210106 11:58:04 web:2250] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1) 3.58ms[W 2021-01-06 11:58:06.236 EnterpriseGatewayApp] No session ID specified[W 210106 11:58:06 web:1786] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1): Kernel does not exist: ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9[W 210106 11:58:06 web:2250] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1) 3.32ms[W 2021-01-06 11:58:08.606 EnterpriseGatewayApp] No session ID specified[W 210106 11:58:08 web:1786] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1): Kernel does not exist: ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9[W 210106 11:58:08 web:2250] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1) 3.27ms[W 2021-01-06 11:58:12.771 EnterpriseGatewayApp] No session ID specified[W 210106 11:58:12 web:1786] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1): Kernel does not exist: ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9[W 210106 11:58:12 web:2250] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1) 3.76ms[W 2021-01-06 11:58:20.920 EnterpriseGatewayApp] No session ID specified[W 210106 11:58:20 web:1786] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1): Kernel does not exist: ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9[W 210106 11:58:20 web:2250] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1) 2.83ms[W 2021-01-06 11:58:37.837 EnterpriseGatewayApp] No session ID specified[W 210106 11:58:37 web:1786] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1): Kernel does not exist: ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9[W 210106 11:58:37 web:2250] 404 GET /api/kernels/ce5cdbbb-a718-4f6c-b91a-09b0ac51a3a9/channels (127.0.0.1) 2.48ms

There are timings in power of two so that seems to work proper

@oyvsyooyvsyo marked this pull request as ready for reviewJanuary 6, 2021 15:03
Copy link
Member

@kevin-bateskevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good Dvoiak - thank you. Please post a similar PR to jupyter_server when you can. (I believe you had confirmed that previously, but I no longer see that comment.)

oyvsyo reacted with thumbs up emoji
@kevin-bateskevin-bates merged commit71e402f intojupyter:masterJan 6, 2021
@blink1073blink1073 added this to the6.2 milestoneMar 18, 2021
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsSep 15, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@kevin-bateskevin-bateskevin-bates approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

3 participants

@oyvsyo@kevin-bates@blink1073
[8]ページ先頭
©2009-2025 Movatter.jp