- Notifications
You must be signed in to change notification settings - Fork5.5k
Handle TrashPermissionError, now that it exists#5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_check_trash() was added (injupyter#3304) because TrashPermissionError didn'texist, yet.Now that it does, we can use it, and stop guessing what will cause apermission problem.Closes:jupyter#3374
If the test working directory isn't trashable, we expect to not be ableto delete the non-empty directory.
kevin-bates approved these changesDec 22, 2020
Member
kevin-bates left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice cleanup - thank you.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
In Ubuntu's automated test environmentfull log example, both HOME and the temporary directories are likely to be on a tmpfs. That will cause
gi.repository.GLib.GError: g-io-error-quark: Trashing on system internal mounts is not supported (15)which will raise aTrashPermissionError.As the comments in the code indicate,
_check_trash()was added (in#3304) becauseTrashPermissionErrordidn'texist, yet. We asked send2trash to implement such an exception, so that we wouldn't have to guess whether a file was trash-able or not, and they did. So, let's take advantage of it.
Because we don't permanently delete, recursively,
test_delete_non_empty_dirwill now fail in environments where the test data isn't trash-able. So, handle that, and skip the test gracefully.Closes:#3374