- Notifications
You must be signed in to change notification settings - Fork5.5k
do not require nose for testing#5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kevin-bates left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
These changes look good - thank you! Only had the one comment regarding the print statements.
notebook/tests/test_paths.py Outdated
| ): | ||
| assert_regex(path,path_pat) | ||
| print(type(path)) | ||
| print(type(path_pat)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should probably remove theseprint statements.
kevin-bates left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@pgajdos.
hroncok commentedJan 7, 2021
Note that nose appears still required viahttps://github.com/ipython/ipython_genutils/blob/fbcb174d06d6df1f8633014dd80fad8c45533c2e/ipython_genutils/testing/decorators.py#L162 |
kevin-bates commentedJan 8, 2021
Good catch@hroncok - thanks. Looks like the updates to At any rate, PR forthcoming to address the remaining references that pull in |
hroncok commentedJan 8, 2021
AFAIK nose comes pre-installed in Travis Python environments (I guess historically this was a good idea, not sure). |
noseis deprecated and will not work in future python versions.