- Notifications
You must be signed in to change notification settings - Fork5.5k
Require a file name in the "Save As" dialog#5733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
kevin-bates left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This tests out great - thank you. I'm going to ask another maintainer to review the changes.
kevin-bates commentedSep 5, 2020
Steve, I'm hoping you can take a look at the changes. They test out fine on my end. Thank you. |
blink1073 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks reasonable to me, thanks!
This PRfixes#5732 by checking for empty file names in the "Save As" dialog and refusing to save the file. It also helpfully highlights the instructions to the user in red.
It would be better if the error message were clearer, or even better if the save button were disabled until a file name was entered, but that would require a much larger and more complex change to the code. (Maintainers, feel free to take this patch and run with it!)