Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix typo for Check in zh_CN#5730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kevin-bates merged 3 commits intojupyter:masterfrombdbai:patch-1
Sep 5, 2020
Merged

Conversation

@bdbai
Copy link
Contributor

检查(check) and检出(check out) sound similar, but their meaning is different. In this context, it should be检查.

Copy link
Member

@kevin-bateskevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the update@bdbai .

Since I don't read Chinese I placed the two strings ingoogle translate and see that the phrase:

, please check out the network connection... and the service configuration.

becomes:

, please check the network connection... and the service configuration.

(sans 'out') - which I agree is better - although google translate is certainly not definitive.

I'm curious if the ellipses ('...') are necessary? I'm approving anyway, just curious.

@bdbai
Copy link
ContributorAuthor

@kevin-bates thanks for approval!

I'm curious if the ellipses ('...') are necessary? I'm approving anyway, just curious.

I don't think the ellipses here are necessary. Actually they give me a sense of uncertainty or hesitation, just like how we feel when they appear in English.

@kevin-bates
Copy link
Member

kevin-bates commentedSep 4, 2020
edited
Loading

@bdbai - would it make sense to go ahead and remove the ellipses since that hesitation seems unnecessary here?

@bdbai
Copy link
ContributorAuthor

@kevin-bates done. There are many more ellipses in this translation. Do you think it is necessary to remove them as well?

@kevin-bates
Copy link
Member

Thank you for the update and offer. It looks like many of the remaining ellipses are trailing - where hesitation is appropriate (e.g., "Restoring to checkpoint..."), but I listed the two additional translations where the English string does not have ellipses while the translation does. If you could review these, that would be greatly appreciated...

@bdbai
Copy link
ContributorAuthor

Sorry for the late reply because I am currently on a trip.

While reviewing other phrases, I also found some flaws in this translate, such as wrong usage of half-width punctuation (should be full width for Chinese sentences) and lack of spaces between Chinese characters and English or numbers. However, they are out of the scope of this issue. Would you mind my opening another issue after fixing them?

@kevin-bates
Copy link
Member

That sounds like the right approach - thank you.

@kevin-bateskevin-bates merged commit5af2343 intojupyter:masterSep 5, 2020
@bdbaibdbai mentioned this pull requestSep 29, 2020
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@kevin-bateskevin-bateskevin-bates approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bdbai@kevin-bates

[8]ページ先頭

©2009-2025 Movatter.jp